Fixing GetSourceRequest #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: Vacha Shah <vachshah@amazon.com>
dblock
approved these changes
Oct 23, 2023
|
|
||
| ```go | ||
| getSourceRequest := opensearchapi.GetSourceRequest{ | ||
| Index: "movies", |
There was a problem hiding this comment.
Ah! I will fix it in a open PR :)
VachaShah
added a commit
to VachaShah/opensearch-go
that referenced
this pull request
Oct 23, 2023
* Fixing GetSourceRequest source field Signed-off-by: Vacha Shah <vachshah@amazon.com> * Adding sample code for get source api Signed-off-by: Vacha Shah <vachshah@amazon.com> * Adding changelog Signed-off-by: Vacha Shah <vachshah@amazon.com> --------- Signed-off-by: Vacha Shah <vachshah@amazon.com>
dblock
pushed a commit
that referenced
this pull request
Oct 23, 2023
* Cleaning up changelog and updating documentation (#401) * Cleaning up changelog Signed-off-by: Vacha Shah <vachshah@amazon.com> * Updating compatibility matrix Signed-off-by: Vacha Shah <vachshah@amazon.com> --------- Signed-off-by: Vacha Shah <vachshah@amazon.com> * Fixing GetSourceRequest (#402) * Fixing GetSourceRequest source field Signed-off-by: Vacha Shah <vachshah@amazon.com> * Adding sample code for get source api Signed-off-by: Vacha Shah <vachshah@amazon.com> * Adding changelog Signed-off-by: Vacha Shah <vachshah@amazon.com> --------- Signed-off-by: Vacha Shah <vachshah@amazon.com> --------- Signed-off-by: Vacha Shah <vachshah@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Source parameter in GetSourceRequest is not correctly defined. Fixing that and adding tests and samples for the GetSource API.
Issues Resolved
Fixes #283
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.