Upgrading to go 1.21 version and jsondiff to 0.5.1 #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #509 +/- ##
=======================================
Coverage 57.29% 57.29%
=======================================
Files 315 315
Lines 9823 9823
=======================================
Hits 5628 5628
Misses 2902 2902
Partials 1293 1293
Flags with carried forward coverage won't be shown. Click here to find out more. |
Jakob3xD
previously approved these changes
Apr 5, 2024
Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: Vacha Shah <vachshah@amazon.com>
VachaShah
force-pushed
the
upgrade-go-and-jsondiff
branch
from
20c03de
to
1a1fa4c
Compare
|
@Jakob3xD Can I get an approval again? Had to rebase due to conflicts in CHANGELOG. Thank you! |
Jakob3xD
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Coming from #480,
jsondiffupgrade needs go 1.21+.Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.