-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing failure fields in opensearchapi structs #510
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #510 +/- ##
==========================================
+ Coverage 57.29% 63.24% +5.94%
==========================================
Files 315 315
Lines 9823 7715 -2108
==========================================
- Hits 5628 4879 -749
+ Misses 2902 1550 -1352
+ Partials 1293 1286 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I am not sure how I can setup a broken Opensearch to test this in a practical way. |
c2b8f67
to
88aa8c3
Compare
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
88aa8c3
to
873eb33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to us. This stuff should really be generated from spec.
Signed-off-by: Daniel (dB.) Doubrovkine <dblock@dblock.org>
Description
Add missing failure fields in opensearchapi structs displayed by errors:
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:79
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:206
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:211
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:425
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:564
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:647
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:877
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:890
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:911
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:918
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:925
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:940
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:949
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:957
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:965
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:980
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:1197
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:1215
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:1237
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:1255
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:1466
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:1486
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:1497
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:1510
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.