Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing failure fields in opensearchapi structs #510

Merged
merged 8 commits into from
Apr 10, 2024

Conversation

Jakob3xD
Copy link
Collaborator

@Jakob3xD Jakob3xD commented Apr 5, 2024

Description

Add missing failure fields in opensearchapi structs displayed by errors:
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:79
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:206
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:211
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:425
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:564
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:647
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:877
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:890
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:911
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:918
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:925
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:940
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:949
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:957
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:965
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:980
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:1197
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:1215
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:1237
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:1255
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:1466
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:1486
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:1497
https://github.com/opensearch-project/opensearch-go/actions/runs/8560050080/job/23458155375#step:7:1510

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.24%. Comparing base (06a6dc8) to head (a1b6fd0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #510      +/-   ##
==========================================
+ Coverage   57.29%   63.24%   +5.94%     
==========================================
  Files         315      315              
  Lines        9823     7715    -2108     
==========================================
- Hits         5628     4879     -749     
+ Misses       2902     1550    -1352     
+ Partials     1293     1286       -7     
Flag Coverage Δ
integration 55.78% <ø> (+4.94%) ⬆️
unit 81.45% <ø> (+68.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
opensearchapi/api_bulk.go 100.00% <ø> (ø)
opensearchapi/api_cat-nodeattrs.go 100.00% <ø> (ø)
opensearchapi/api_cat-nodes.go 100.00% <ø> (ø)
opensearchapi/api_cluster-stats.go 100.00% <ø> (ø)
opensearchapi/api_datastream-stats.go 100.00% <ø> (ø)
...archapi/api_document-delete_by_query_rethrottle.go 100.00% <ø> (ø)
opensearchapi/api_indices-block.go 100.00% <ø> (ø)
opensearchapi/api_indices-cache.go 100.00% <ø> (ø)
opensearchapi/api_indices-close.go 100.00% <ø> (ø)
opensearchapi/api_indices-flush.go 100.00% <ø> (ø)
... and 14 more

... and 229 files with indirect coverage changes

@Jakob3xD
Copy link
Collaborator Author

Jakob3xD commented Apr 5, 2024

I am not sure how I can setup a broken Opensearch to test this in a practical way.

@Jakob3xD Jakob3xD marked this pull request as ready for review April 5, 2024 12:23
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
dblock
dblock previously approved these changes Apr 10, 2024
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to us. This stuff should really be generated from spec.

Signed-off-by: Daniel (dB.) Doubrovkine <dblock@dblock.org>
@dblock dblock merged commit 3e5f0de into opensearch-project:main Apr 10, 2024
53 checks passed
@Jakob3xD Jakob3xD deleted the jh-missing-fields branch April 10, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants