Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opensearch: increase test coverage #517

Merged
merged 8 commits into from
Apr 10, 2024

Conversation

Jakob3xD
Copy link
Collaborator

@Jakob3xD Jakob3xD commented Apr 8, 2024

Description

Depends on #512 to be merged first.

  • removed unused structs and functions from opensearch
  • adjust opensearch test to increase coverage
  • fix opensearchtransport to check for empty response body

Issues Resolved

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Jakob3xD Jakob3xD changed the title Jh cleanup opensearch: increase test coverage Apr 8, 2024
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
@Jakob3xD Jakob3xD force-pushed the jh-cleanup branch 3 times, most recently from 05f2275 to ad71873 Compare April 9, 2024 07:58
@Jakob3xD Jakob3xD marked this pull request as ready for review April 9, 2024 08:05
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.24%. Comparing base (06a6dc8) to head (8a15689).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #517      +/-   ##
==========================================
+ Coverage   57.29%   63.24%   +5.94%     
==========================================
  Files         315      315              
  Lines        9823     7715    -2108     
==========================================
- Hits         5628     4879     -749     
+ Misses       2902     1550    -1352     
+ Partials     1293     1286       -7     
Flag Coverage Δ
integration 55.78% <0.00%> (+4.94%) ⬆️
unit 81.45% <100.00%> (+68.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
opensearch.go 92.72% <100.00%> (+17.10%) ⬆️
opensearchtransport/discovery.go 64.70% <100.00%> (+1.62%) ⬆️

... and 248 files with indirect coverage changes

@dblock dblock merged commit 38b48ff into opensearch-project:main Apr 10, 2024
53 checks passed
@Jakob3xD Jakob3xD deleted the jh-cleanup branch April 10, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants