Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes opensearch-project/opensearch-go#522 #523

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

martingrzzler
Copy link
Contributor

Description

Add test for 429 example response. Handle the error with an added sentinel.

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.20%. Comparing base (06a6dc8) to head (7f4c2e0).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #523      +/-   ##
==========================================
+ Coverage   57.29%   66.20%   +8.91%     
==========================================
  Files         315      364      +49     
  Lines        9823     8585    -1238     
==========================================
+ Hits         5628     5684      +56     
+ Misses       2902     1589    -1313     
- Partials     1293     1312      +19     
Flag Coverage Δ
integration 59.54% <0.00%> (+8.70%) ⬆️
unit 81.64% <100.00%> (+68.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
error.go 100.00% <100.00%> (ø)

... and 251 files with indirect coverage changes

@dblock
Copy link
Member

dblock commented Apr 10, 2024

Add a line to CHANGELOG please and we're good to go.

@dblock
Copy link
Member

dblock commented Apr 10, 2024

Also see #522 (comment)

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Would be great to have a section in the user guide on error handling.

@dblock
Copy link
Member

dblock commented Apr 11, 2024

@martingrzzler You have to sign all your commits with DCO please (git commit -s --amend and force push).

Signed-off-by: Martin Gressler <martin.gressler@code.berlin>
Signed-off-by: Martin Gressler <martin.gressler@code.berlin>
Signed-off-by: Martin Gressler <martin.gressler@code.berlin>
@Jakob3xD Jakob3xD merged commit c685fa6 into opensearch-project:main Apr 12, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants