Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use go:build tags for testing #529

Merged
merged 5 commits into from
Apr 16, 2024
Merged

Conversation

Jakob3xD
Copy link
Collaborator

Description

  • add go:build tags to integ tests
  • add options to makefile to select integ test
  • use new make functions in workflows
    Followup PR for Add ISM Policy #524 (review)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.99%. Comparing base (06a6dc8) to head (60708bd).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #529      +/-   ##
==========================================
+ Coverage   57.29%   66.99%   +9.70%     
==========================================
  Files         315      376      +61     
  Lines        9823     8850     -973     
==========================================
+ Hits         5628     5929     +301     
+ Misses       2902     1599    -1303     
- Partials     1293     1322      +29     
Flag Coverage Δ
integration 60.38% <ø> (+9.54%) ⬆️
unit 81.64% <ø> (+68.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 250 files with indirect coverage changes

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

Let's rename things to be more consistent.

OpenSeearch engine is called either "core" (that's how we refer to the repo) or "min" (that's the name of the distribution), so rename "base" to "core" or "min"?

Since we're testing multiple plugins let's call "plugin" "plugins"?

To avoid confusion between things like "integration", I think we should prefix plugin tags with "plugin", e.g. "plugin-security" and name plugins to match their actual name, so instead of "ism" let's call it "index-management".

Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
…e normal integ test

Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean.

@dblock dblock merged commit d98790b into opensearch-project:main Apr 16, 2024
53 checks passed
@Jakob3xD Jakob3xD deleted the jh-testing branch April 16, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants