Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Signing Request feature #81

Merged
merged 2 commits into from Jan 6, 2022

Conversation

VijayanB
Copy link
Member

@VijayanB VijayanB commented Jan 5, 2022

Description

  • Add support to sign request
  • Add support to sign using AWS Sigv4

Issues Resolved

#75

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Allow users to implement interface which can
sign request.

Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
@VijayanB VijayanB requested review from svencowart and a team as code owners January 5, 2022 04:41
@VijayanB VijayanB self-assigned this Jan 5, 2022
@VijayanB VijayanB added 1.1.0 enhancement New feature or request labels Jan 5, 2022
dblock
dblock previously approved these changes Jan 5, 2022
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some smallish comments, looks good to my Go knowledge.

opensearchtransport/opensearchtransport.go Show resolved Hide resolved
signer/aws/aws.go Outdated Show resolved Hide resolved
signer/aws/aws.go Outdated Show resolved Hide resolved
signer/aws/aws.go Outdated Show resolved Hide resolved
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
@VijayanB VijayanB merged commit 279a4bf into opensearch-project:main Jan 6, 2022
@rm-hull rm-hull mentioned this pull request Feb 9, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.1.0 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants