Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restoring skipped pushdown tests #125

Merged

Conversation

harshavamsi
Copy link
Collaborator

@harshavamsi harshavamsi commented Feb 25, 2023

Description

Restores tests that were skipped as part of #42 since they've been fixed in upstream.

Issues Resolved

Closes #41

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
@harshavamsi harshavamsi merged commit 038c5d5 into opensearch-project:main Feb 25, 2023
@harshavamsi harshavamsi deleted the fix/restore-pushdown-tests branch February 25, 2023 20:06
@opensearch-trigger-bot
Copy link

The backport to 1.0 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.0 1.0
# Navigate to the new working tree
pushd ../.worktrees/backport-1.0
# Create a new branch
git switch --create backport/backport-125-to-1.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 038c5d5fd18d59fa408de6e65476844979329993
# Push it to GitHub
git push --set-upstream origin backport/backport-125-to-1.0
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.0

Then, create a pull request where the base branch is 1.0 and the compare/head branch is backport/backport-125-to-1.0.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 25, 2023
* Restoring skipped pushdown tests

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Fix backport workflow

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

---------

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
(cherry picked from commit 038c5d5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
harshavamsi pushed a commit that referenced this pull request Feb 26, 2023
* Restoring skipped pushdown tests



* Fix backport workflow



---------


(cherry picked from commit 038c5d5)

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] strict parameter not honored in SparkSqlScalaSuite
1 participant