Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses Jackson JSON serialization instead of ObjectInputStream to deserialize objects #154

Merged

Conversation

harshavamsi
Copy link
Collaborator

@harshavamsi harshavamsi commented Mar 20, 2023

Description

Uses Jackson JSON serialization instead of ObjectInputStream to deserialize objects

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@harshavamsi harshavamsi changed the title Uses DataInputStream instead of ObjectInputStream to deserialize objects Uses Jackson JSON serialization instead of ObjectInputStream to deserialize objects Mar 30, 2023
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
@harshavamsi harshavamsi merged commit f1db6ce into opensearch-project:main Apr 3, 2023
10 checks passed
@opensearch-trigger-bot
Copy link

The backport to 2.0 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.0 2.0
# Navigate to the new working tree
pushd ../.worktrees/backport-2.0
# Create a new branch
git switch --create backport/backport-154-to-2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f1db6ce13c8d341fcc0ff94b3f2daae859fa8547
# Push it to GitHub
git push --set-upstream origin backport/backport-154-to-2.0
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.0

Then, create a pull request where the base branch is 2.0 and the compare/head branch is backport/backport-154-to-2.0.

@opensearch-trigger-bot
Copy link

The backport to 1.0 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.0 1.0
# Navigate to the new working tree
pushd ../.worktrees/backport-1.0
# Create a new branch
git switch --create backport/backport-154-to-1.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f1db6ce13c8d341fcc0ff94b3f2daae859fa8547
# Push it to GitHub
git push --set-upstream origin backport/backport-154-to-1.0
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.0

Then, create a pull request where the base branch is 1.0 and the compare/head branch is backport/backport-154-to-1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant