Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding release workflow #227

Merged
merged 4 commits into from May 18, 2023

Conversation

harshavamsi
Copy link
Collaborator

Description

Describe what this change achieves.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@harshavamsi harshavamsi requested a review from nknize as a code owner May 17, 2023 23:38
Copy link

@VachaShah VachaShah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments:

  • Build workflows are failing, can you take a look @harshavamsi?
  • Also, can you add a Changelog entry?

jenkins/release.jenkinsFile Outdated Show resolved Hide resolved
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
@harshavamsi
Copy link
Collaborator Author

A few comments:

* Build workflows are failing, can you take a look @harshavamsi?

* Also, can you add a Changelog entry?

Spark-20 workflow is failing but has no impact on release, will open up an issue to track, the rest of the tests should be fixed.

Added changelog entry.

Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is the first release we want to check the artifacts content before publishing to maven central.

jenkins/release.jenkinsFile Outdated Show resolved Hide resolved
jenkins/release.jenkinsFile Outdated Show resolved Hide resolved
harshavamsi and others added 3 commits May 18, 2023 10:33
Co-authored-by: Sayali Gaikawad <61760125+gaiksaya@users.noreply.github.com>
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Co-authored-by: Sayali Gaikawad <61760125+gaiksaya@users.noreply.github.com>
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Co-authored-by: Sayali Gaikawad <61760125+gaiksaya@users.noreply.github.com>
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the credentials for webhook. Will add the actual webhook after this PR is merged!

@harshavamsi harshavamsi merged commit 702abd6 into opensearch-project:main May 18, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants