Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gradle to 8.5 #377

Merged
merged 6 commits into from
Jan 8, 2024
Merged

Conversation

reta
Copy link
Contributor

@reta reta commented Dec 19, 2023

Description

Update Gradle to 8.5

Issues Resolved

Part of opensearch-project/OpenSearch#10334

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@@ -46,24 +46,18 @@ configurations {
// This will force the MR project to require jars from upstream project dependencies, which shouldn't be a problem since
// there should only be one upstream project.
compileClasspath {
beforeLocking {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See please gradle/gradle#25126

Copy link
Collaborator

@Xtansia Xtansia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @reta!

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@reta
Copy link
Contributor Author

reta commented Dec 19, 2023

Thanks for this @reta!

Thanks @Xtansia , updated the OpenSearch version (that brings new Gradle plugins), have one issue to fix:

> Configure project :opensearch-spark-30                                              
The org.gradle.api.plugins.Convention type has been deprecated. This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for further information: https:
//docs.gradle.org/8.5/userguide/upgrading_version_8.html#deprecated_access_to_conventions                                                                                 
        at build_6nu7is0k4y2vnu5md65y4hre5$_run_closure1.doCall$original(/home/andriy.redko/Workspaces/OpenSearch-plugins/opensearch-hadoop/spark/sql-30/build.gradle:13)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@Xtansia
Copy link
Collaborator

Xtansia commented Dec 19, 2023

@reta I can see one other error

* What went wrong:
Execution failed for task ':dist:generatePomFileForMainPublication'.

> Could not apply withXml() to generated POM
   > Could not get unknown property 'archivesName' for project ':dist' of type org.gradle.api.Project.

@reta
Copy link
Contributor Author

reta commented Dec 19, 2023

@reta I can see one other error

Yep, thanks @Xtansia , fixed it but didn't push till checks pass

@reta
Copy link
Contributor Author

reta commented Dec 20, 2023

It seems like I may need to use 2.12.0-SNAPSHOT for OpenSearch build tools...

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@Xtansia
Copy link
Collaborator

Xtansia commented Jan 7, 2024

@reta Looks like you didn't end up needing to depend on a SNAPSHOT, so this should be good to merge right?

@reta
Copy link
Contributor Author

reta commented Jan 8, 2024

@reta Looks like you didn't end up needing to depend on a SNAPSHOT, so this should be good to merge right?

Correct, 2.11.1 did the trick, thanks @Xtansia !

@Xtansia Xtansia merged commit ff60571 into opensearch-project:main Jan 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants