Fix: do not double-wrap OpenSearchException. #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
requested review from
reta,
Bukhtawar,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
dblock
force-pushed
the
do-not-wrap-exception
branch
from
2135314
to
3da155c
Compare
reta
reviewed
Jan 11, 2023
| @@ -456,6 +457,8 @@ private <ResponseT, ErrorT> ResponseT parseResponse( | |||
| ErrorT error = errorDeserializer.deserialize(parser, mapper); | |||
| throw new OpenSearchException((ErrorResponse) error); | |||
| } | |||
| } catch (OpenSearchException e) { | |||
There was a problem hiding this comment.
Would be good to cover that with tests ... :-)
reta
previously approved these changes
Jan 11, 2023
dblock
force-pushed
the
do-not-wrap-exception
branch
from
3da155c
to
311df50
Compare
Signed-off-by: dblock <dblock@amazon.com>
dblock
force-pushed
the
do-not-wrap-exception
branch
from
311df50
to
36bfa27
Compare
reta
previously approved these changes
Jan 12, 2023
|
@VachaShah care for a 2PR? thanks! |
VachaShah
previously approved these changes
Jan 14, 2023
reta
approved these changes
Jan 15, 2023
|
@VachaShah need one more pls |
VachaShah
approved these changes
Jan 17, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 17, 2023
Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: dblock <dblock@amazon.com> (cherry picked from commit 37d4800)
dblock
added a commit
that referenced
this pull request
Jan 17, 2023
Signed-off-by: dblock <dblock@amazon.com> (cherry picked from commit 37d4800)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dblock dblock@amazon.com
Description
Before:
After:
Help me write a unit test for this? Is it worth it?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.