Added support for signing service name (partial support for OpenSearch Serverless) #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
requested review from
reta,
Bukhtawar,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
dblock
force-pushed
the
opensearch-serverless
branch
from
4b6f5e5
to
f8aef5d
Compare
VachaShah
reviewed
Jan 11, 2023
...t/src/test/java/org/opensearch/client/opensearch/integTest/aws/AwsSdk2TransportTestCase.java
Outdated
Show resolved
Hide resolved
java-client/src/main/java/org/opensearch/client/transport/aws/AwsSdk2Transport.java
Outdated
Show resolved
Hide resolved
dblock
force-pushed
the
opensearch-serverless
branch
2 times, most recently
from
5998b8e
to
f530a36
Compare
Signed-off-by: dblock <dblock@amazon.com>
dblock
force-pushed
the
opensearch-serverless
branch
from
f530a36
to
1f2a00d
Compare
reta
reviewed
Jan 13, 2023
| @@ -96,20 +96,42 @@ public AwsSdk2Transport( | |||
| @Nonnull String host, | |||
| @Nonnull Region signingRegion, | |||
| @CheckForNull AwsSdk2TransportOptions options) { | |||
| this(httpClient, null, host, signingRegion, options); | |||
| this(httpClient, null, host, "es", signingRegion, options); | |||
There was a problem hiding this comment.
Suggested change
| this(httpClient, null, host, "es", signingRegion, options); | |
| this(httpClient, null, host, "os", signingRegion, options); |
There was a problem hiding this comment.
Seem like es -> elasticsearch? :)
There was a problem hiding this comment.
Oh sorry, I see it now - the value is coming from AWS, it the values are limited by these two choices, make it an enum? signingServiceName looks like pretty free style choice ...
There was a problem hiding this comment.
I think I'd prefer it to be a string because I am not so sure that list is finite. I'm trying to find out whether the signing service name can be other than es and aoss in the case of a proxy. Can we leave it as is for now?
reta
previously approved these changes
Jan 13, 2023
reta
approved these changes
Jan 15, 2023
VachaShah
approved these changes
Jan 17, 2023
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-324-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6096034b0599ebb416d3ea8ff2fe40d86b12674c
# Push it to GitHub
git push --set-upstream origin backport/backport-324-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
dblock
added a commit
to dblock/opensearch-java
that referenced
this pull request
Jan 18, 2023
Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: dblock <dblock@amazon.com> (cherry picked from commit 6096034)
dblock
added a commit
to dblock/opensearch-java
that referenced
this pull request
Jan 18, 2023
Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: dblock <dblock@amazon.com> (cherry picked from commit 6096034)
Merged
reta
pushed a commit
that referenced
this pull request
Jan 19, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dblock dblock@amazon.com
Description
Added support for signing service name. This is a necessary prerequisite for OpenSearch Serverless.
Issues Resolved
Related to #287
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.