Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Publish snapshots from 2.x branch (#451) #454

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

VachaShah
Copy link
Collaborator

Description

Publish snapshots workflow did not get triggered with just the change on main in PR #451. The workflow needs to be present on the respective branches.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: Vacha Shah <vachshah@amazon.com>
@reta
Copy link
Collaborator

reta commented Apr 13, 2023

@VachaShah I thought you were about to remove it since main workflow does all branches?

on:
push:
branches:
- main
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- main
- 2.x

@VachaShah
Copy link
Collaborator Author

@VachaShah I thought you were about to remove it since main workflow does all branches?

Yeah we were trying if the workflow is just present on the main branch with a list of all branches, would it publish the snapshot for 2.x on push to 2.x. But the workflow needs to be present on each branch so I am backporting the workflow here on 2.x.

@VachaShah VachaShah merged commit 34e544f into opensearch-project:2.x Apr 14, 2023
@VachaShah VachaShah deleted the 2.x branch April 14, 2023 18:44
@BrendonFaleiro BrendonFaleiro mentioned this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants