fix: add missing translog sync interval option to index settings #518

Mstrutov · 2023-06-06T04:50:53Z

Description

Now we can set translog sync interval option via client.

Additionally, server response contains separate translog object, which cannot be deserialized by present translog option deserializers.
It looks like this:

{
  "test-settings": {
    "settings": {
      "index": {
        "number_of_shards": "1",
        "translog": {
          "sync_interval": "10s",
          "durability": "async"
        },
        "provided_name": "test-settings",
        "creation_date": "1685967681952",
        "number_of_replicas": "1",
        "uuid": "q4R3eDKjT164eR_NNuY8pQ",
        "version": {
          "created": "136257827"
        }
      }
    }
  }
}

Therefore, a corresponding Translog class is introduced, similarly to how it is done for the blocks property.

Issues Resolved

Closes #307

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

java-client/src/main/java/org/opensearch/client/opensearch/indices/IndexSettings.java

java-client/src/test/java/org/opensearch/client/opensearch/experiments/ParsingTests.java

java-client/src/main/java/org/opensearch/client/opensearch/indices/IndexSettings.java

dblock

I have some nice to have's but this is good by me. Up to you if you want to address them.

java-client/src/test/java/org/opensearch/client/opensearch/experiments/ParsingTests.java

CHANGELOG.md

dblock · 2023-06-26T22:49:49Z

LGTM! @reta?

CHANGELOG.md

Additionally, server response contains separate `translog` object, which cannot be deserialized by present translog option deserializers. Therefore, this commit introduces a corresponding `Translog` class, similarly to how it is done for the `blocks` property. Signed-off-by: Maksim Strutovskii <strutovsky.m.a@gmail.com>

Now that all the translog options are stored in a separate object, we should remove the separate fields to avoid confusion. Public methods (getters, builder setters) should remain intact, mark them deprecated and point them to the corresponding translog fields. Deserializer should still recognize string-valued translog attributes, keep the deprecated setters as field deserializers. Serializer does not have to produce string-valued translog attributes, as server parses `translog` attribute. Do not write translog contents to old `translog.xxx` fields. Signed-off-by: Maksim Strutovskii <strutovsky.m.a@gmail.com>

…zation Signed-off-by: Maksim Strutovskii <strutovsky.m.a@gmail.com>

VachaShah

Thank you @Mstrutov!

* fix: add missing translog sync interval option to index settings Additionally, server response contains separate `translog` object, which cannot be deserialized by present translog option deserializers. Therefore, this commit introduces a corresponding `Translog` class, similarly to how it is done for the `blocks` property. Signed-off-by: Maksim Strutovskii <strutovsky.m.a@gmail.com> * fix: encapsulate translog options into translog in index settings Now that all the translog options are stored in a separate object, we should remove the separate fields to avoid confusion. Public methods (getters, builder setters) should remain intact, mark them deprecated and point them to the corresponding translog fields. Deserializer should still recognize string-valued translog attributes, keep the deprecated setters as field deserializers. Serializer does not have to produce string-valued translog attributes, as server parses `translog` attribute. Do not write translog contents to old `translog.xxx` fields. Signed-off-by: Maksim Strutovskii <strutovsky.m.a@gmail.com> * refactor: use ModelTestCase in tests for json serialization/deserialization Signed-off-by: Maksim Strutovskii <strutovsky.m.a@gmail.com> --------- Signed-off-by: Maksim Strutovskii <strutovsky.m.a@gmail.com> (cherry picked from commit 1323796) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

… (#544) * fix: add missing translog sync interval option to index settings Additionally, server response contains separate `translog` object, which cannot be deserialized by present translog option deserializers. Therefore, this commit introduces a corresponding `Translog` class, similarly to how it is done for the `blocks` property. * fix: encapsulate translog options into translog in index settings Now that all the translog options are stored in a separate object, we should remove the separate fields to avoid confusion. Public methods (getters, builder setters) should remain intact, mark them deprecated and point them to the corresponding translog fields. Deserializer should still recognize string-valued translog attributes, keep the deprecated setters as field deserializers. Serializer does not have to produce string-valued translog attributes, as server parses `translog` attribute. Do not write translog contents to old `translog.xxx` fields. * refactor: use ModelTestCase in tests for json serialization/deserialization --------- (cherry picked from commit 1323796) Signed-off-by: Maksim Strutovskii <strutovsky.m.a@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Mstrutov requested review from reta, Bukhtawar, dblock, szczepanczykd, madhusudhankonda, saratvemulapalli and VachaShah as code owners June 6, 2023 04:50

Mstrutov force-pushed the fix/add-translog-sync-interval-to-index-settings branch 2 times, most recently from 5ecc6c7 to 6ba68d8 Compare June 6, 2023 04:59

reta reviewed Jun 6, 2023

View reviewed changes

java-client/src/main/java/org/opensearch/client/opensearch/indices/IndexSettings.java Outdated Show resolved Hide resolved

reta reviewed Jun 7, 2023

View reviewed changes

java-client/src/main/java/org/opensearch/client/opensearch/indices/IndexSettings.java Outdated Show resolved Hide resolved

reta reviewed Jun 7, 2023

View reviewed changes

java-client/src/test/java/org/opensearch/client/opensearch/experiments/ParsingTests.java Outdated Show resolved Hide resolved

reta previously approved these changes Jun 7, 2023

View reviewed changes

Mstrutov dismissed reta’s stale review via ff2f996 June 8, 2023 12:10

Mstrutov force-pushed the fix/add-translog-sync-interval-to-index-settings branch from f849a4e to ff2f996 Compare June 8, 2023 12:10

Mstrutov requested a review from reta June 8, 2023 12:11

Mstrutov force-pushed the fix/add-translog-sync-interval-to-index-settings branch from ff2f996 to 410e08f Compare June 8, 2023 12:28

reta previously approved these changes Jun 8, 2023

View reviewed changes

dblock previously approved these changes Jun 12, 2023

View reviewed changes

java-client/src/main/java/org/opensearch/client/opensearch/indices/IndexSettings.java Outdated Show resolved Hide resolved

Mstrutov dismissed stale reviews from dblock and reta via 8d06598 June 13, 2023 05:28

Mstrutov force-pushed the fix/add-translog-sync-interval-to-index-settings branch 2 times, most recently from 8d06598 to 891e0fe Compare June 13, 2023 05:35

dblock approved these changes Jun 13, 2023

View reviewed changes

java-client/src/test/java/org/opensearch/client/opensearch/experiments/ParsingTests.java Outdated Show resolved Hide resolved

java-client/src/test/java/org/opensearch/client/opensearch/experiments/ParsingTests.java Outdated Show resolved Hide resolved

dblock previously approved these changes Jun 13, 2023

View reviewed changes

Mstrutov dismissed dblock’s stale review via b7d50ca June 15, 2023 07:24

Mstrutov force-pushed the fix/add-translog-sync-interval-to-index-settings branch 2 times, most recently from b7d50ca to 86078bb Compare June 15, 2023 07:36

Mstrutov requested a review from dblock June 15, 2023 08:01

dblock previously approved these changes Jun 20, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

dblock requested a review from reta June 20, 2023 12:26

Mstrutov dismissed dblock’s stale review via 4484d87 June 22, 2023 06:27

Mstrutov requested a review from dblock June 22, 2023 06:40

dblock previously approved these changes Jun 26, 2023

View reviewed changes

reta previously approved these changes Jun 27, 2023

View reviewed changes

reta reviewed Jun 27, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

reta reviewed Jun 27, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

VachaShah previously approved these changes Jun 27, 2023

View reviewed changes

Mstrutov dismissed stale reviews from VachaShah, reta, and dblock via a58b899 June 28, 2023 10:51

Mstrutov force-pushed the fix/add-translog-sync-interval-to-index-settings branch from 4484d87 to a58b899 Compare June 28, 2023 10:51

Mstrutov added 3 commits June 28, 2023 13:53

refactor: use ModelTestCase in tests for json serialization/deseriali…

e0f63b5

…zation Signed-off-by: Maksim Strutovskii <strutovsky.m.a@gmail.com>

Mstrutov force-pushed the fix/add-translog-sync-interval-to-index-settings branch from a58b899 to e0f63b5 Compare June 28, 2023 10:53

Mstrutov requested a review from reta June 28, 2023 10:54

reta approved these changes Jun 28, 2023

View reviewed changes

Mstrutov requested a review from dblock June 28, 2023 12:43

VachaShah approved these changes Jun 28, 2023

View reviewed changes

reta merged commit 1323796 into opensearch-project:main Jun 28, 2023
31 checks passed

reta added the backport 2.x Backport to 2.x branch label Jun 28, 2023

opensearch-trigger-bot bot mentioned this pull request Jun 28, 2023

[Backport 2.x] fix: add missing translog sync interval option to index settings #544

Merged

ls-urs-keller mentioned this pull request Jan 19, 2024

Add wrapper to builder ls-urs-keller/opensearch-java#1

Closed

BrendonFaleiro mentioned this pull request Jun 21, 2024

2.x #1045

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: add missing translog sync interval option to index settings #518

fix: add missing translog sync interval option to index settings #518

Mstrutov commented Jun 6, 2023

dblock left a comment

dblock commented Jun 26, 2023

VachaShah left a comment

fix: add missing translog sync interval option to index settings #518

fix: add missing translog sync interval option to index settings #518

Conversation

Mstrutov commented Jun 6, 2023

Description

Issues Resolved

dblock left a comment

Choose a reason for hiding this comment

dblock commented Jun 26, 2023

VachaShah left a comment

Choose a reason for hiding this comment