Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support neural query type #674

Merged
merged 5 commits into from Oct 24, 2023
Merged

Conversation

GranT1337
Copy link
Contributor

Description

Adds support for neural query type for neural text search

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Kirill_Ostanin <Kirill_Ostanin@epam.com>
@GranT1337 GranT1337 reopened this Oct 18, 2023
dblock
dblock previously approved these changes Oct 20, 2023
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Do you think yo could add a doc and a working sample into https://github.com/opensearch-project/opensearch-java/tree/main/guides and https://github.com/opensearch-project/opensearch-java/tree/main/samples as part of this?

@dblock
Copy link
Member

dblock commented Oct 20, 2023

@GranT1337 Looks like you'll need to fix spotless and such ... I'll change this whole CI doesn't run on first time committer nonsense

@reta
Copy link
Collaborator

reta commented Oct 20, 2023

@GranT1337 LGTM as well, please add changelog entry, thank you

Signed-off-by: Kirill Ostanin <grantkirill@gmail.com>
Signed-off-by: Kirill Ostanin <grantkirill@gmail.com>
@GranT1337
Copy link
Contributor Author

Looks good! Do you think yo could add a doc and a working sample into https://github.com/opensearch-project/opensearch-java/tree/main/guides and https://github.com/opensearch-project/opensearch-java/tree/main/samples as part of this?

@dblock Creating a sample is quite difficult. To make a simple example, you need to:

  1. Upload the ML model into a cluster.
  2. Deploy the ML model.
  3. Define an ingest pipeline to create embeddings on the fly.
  4. Create an index to store vector data.
  5. Use the uploaded model for search.

The model is quite large for a simple example, and opensearch-java currently does not allow performing these steps through Java code, i.e., sending JSON text is required.

dblock
dblock previously approved these changes Oct 23, 2023
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this code. I think working samples and documentation are worth it, even if difficult or has a bunch of prerequisites, but I won't hold this PR for it.

Signed-off-by: Kirill Ostanin <grantkirill@gmail.com>
Signed-off-by: Kirill Ostanin <grantkirill@gmail.com>
@dblock dblock merged commit 4603af9 into opensearch-project:main Oct 24, 2023
31 checks passed
@VachaShah VachaShah added the backport 2.x Backport to 2.x branch label Oct 24, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 24, 2023
* Add support neural query type

Signed-off-by: Kirill_Ostanin <Kirill_Ostanin@epam.com>

* fix spotless

Signed-off-by: Kirill Ostanin <grantkirill@gmail.com>

* Update CHANGELOG.md

Signed-off-by: Kirill Ostanin <grantkirill@gmail.com>

* refactoring

Signed-off-by: Kirill Ostanin <grantkirill@gmail.com>

* attempt to restart integration tests

Signed-off-by: Kirill Ostanin <grantkirill@gmail.com>

---------

Signed-off-by: Kirill_Ostanin <Kirill_Ostanin@epam.com>
Signed-off-by: Kirill Ostanin <grantkirill@gmail.com>
Co-authored-by: Kirill Ostanin <grantkirill@gmail.com>
(cherry picked from commit 4603af9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
VachaShah pushed a commit that referenced this pull request Oct 24, 2023
* Add support neural query type



* fix spotless



* Update CHANGELOG.md



* refactoring



* attempt to restart integration tests



---------




(cherry picked from commit 4603af9)

Signed-off-by: Kirill_Ostanin <Kirill_Ostanin@epam.com>
Signed-off-by: Kirill Ostanin <grantkirill@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kirill Ostanin <grantkirill@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants