Add support for icu_collation_keyword field type #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bfindlay <bfindlay@acm.org>
Signed-off-by: bfindlay <bfindlay@acm.org>
Signed-off-by: bfindlay <bfindlay@acm.org>
Bfindlay
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
Signed-off-by: bfindlay <bfindlay@acm.org>
reta
reviewed
Nov 14, 2023
...c/main/java/org/opensearch/client/opensearch/_types/mapping/IcuCollationKeywordProperty.java
Show resolved
Hide resolved
Signed-off-by: bfindlay <bfindlay@acm.org>
reta
approved these changes
Nov 15, 2023
|
Thank you @Bfindlay ! |
dblock
approved these changes
Nov 15, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 15, 2023
* add icu collation keyword Signed-off-by: bfindlay <bfindlay@acm.org> * add licensing Signed-off-by: bfindlay <bfindlay@acm.org> * update changelog Signed-off-by: bfindlay <bfindlay@acm.org> * update changelog pr Signed-off-by: bfindlay <bfindlay@acm.org> * add support for icu collation options Signed-off-by: bfindlay <bfindlay@acm.org> --------- Signed-off-by: bfindlay <bfindlay@acm.org> (cherry picked from commit d8d7a3a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
pushed a commit
that referenced
this pull request
Nov 15, 2023
* add icu collation keyword * add licensing * update changelog * update changelog pr * add support for icu collation options --------- (cherry picked from commit d8d7a3a) Signed-off-by: bfindlay <bfindlay@acm.org> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the icu_collation_keyword field type.
Currently, if you have this common plugin enabled, and on an index mapping it will cause an error
Missing Required Property Builder.<variant kind>when using getting templates or mappings.Issues Resolved
#721
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.