Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk UpdateOperation misses upsert options #744

Closed
fs-chris opened this issue Nov 24, 2023 · 1 comment · Fixed by #748 or #856
Closed

Bulk UpdateOperation misses upsert options #744

fs-chris opened this issue Nov 24, 2023 · 1 comment · Fixed by #748 or #856
Labels
enhancement New feature or request

Comments

@fs-chris
Copy link
Contributor

What is the bug?

This is a follow-up for #282
The update-operation for bulks still misses crucial options like scriptedUpsert whereas the common UpdateRequest contains these options.
Without scriptedUpsert option it's not possible to insert documents by script.

Besides that, the less significant detectNoop is also missing.

How can one reproduce the bug?

n.a.

What is the expected behavior?

UpdateOperation should provide all options that the common UpdateRequest provides.

What is your host/environment?

OpenSearch 2.11
OpenSearch client 2.8.1
Java 17

Do you have any screenshots?

n.a.

Do you have any additional context?

n.a.

@fs-chris fs-chris added bug Something isn't working untriaged labels Nov 24, 2023
fs-chris added a commit to IntegrationMatters/opensearch-java that referenced this issue Nov 27, 2023
fs-chris added a commit to IntegrationMatters/opensearch-java that referenced this issue Nov 27, 2023
fs-chris added a commit to IntegrationMatters/opensearch-java that referenced this issue Nov 29, 2023
Signed-off-by: Christian Winkler <cwinkler@integrationmatters.com>
fs-chris added a commit to IntegrationMatters/opensearch-java that referenced this issue Nov 29, 2023
Signed-off-by: Christian Winkler <cwinkler@integrationmatters.com>
fs-chris added a commit to IntegrationMatters/opensearch-java that referenced this issue Nov 29, 2023
Signed-off-by: Christian Winkler <cwinkler@integrationmatters.com>
fs-chris added a commit to IntegrationMatters/opensearch-java that referenced this issue Nov 29, 2023
Signed-off-by: Christian Winkler <cwinkler@integrationmatters.com>
dblock pushed a commit that referenced this issue Nov 29, 2023
* Added scriptedUpsert option to UpdateOperation (#744)

Signed-off-by: Christian Winkler <cwinkler@integrationmatters.com>

* Added detectNoop option to UpdateOperation (#744)

Signed-off-by: Christian Winkler <cwinkler@integrationmatters.com>

* updated changelog

Signed-off-by: Christian Winkler <cwinkler@integrationmatters.com>

* Added tests

Signed-off-by: Christian Winkler <cwinkler@integrationmatters.com
Signed-off-by: Christian Winkler <cwinkler@integrationmatters.com>

* Running spotlessApply

Signed-off-by: Christian Winkler <cwinkler@integrationmatters.com
Signed-off-by: Christian Winkler <cwinkler@integrationmatters.com>

---------

Signed-off-by: Christian Winkler <cwinkler@integrationmatters.com>
Signed-off-by: Christian Winkler <cwinkler@integrationmatters.com
@dblock
Copy link
Member

dblock commented Nov 29, 2023

#748 was merged and reverted because it was made against a 2.8.1 branch which is only for security patches - looking for a PR on main

@dblock dblock added enhancement New feature or request and removed bug Something isn't working untriaged labels Dec 4, 2023
zjianyu21 pushed a commit to zjianyu21/opensearch-java that referenced this issue Feb 20, 2024
Signed-off-by: Christian Winkler <cwinkler@integrationmatters.com>
zjianyu21 pushed a commit to zjianyu21/opensearch-java that referenced this issue Feb 20, 2024
Signed-off-by: Christian Winkler <cwinkler@integrationmatters.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants