Fixing cluster stats response for role types and adding search role type #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VachaShah
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda and
saratvemulapalli
as code owners
Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: Vacha Shah <vachshah@amazon.com>
VachaShah
force-pushed
the
fix-cluster-stats-api
branch
from
688e62e
to
04e3a92
Compare
dblock
approved these changes
Feb 15, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 15, 2024
…ype (#848) * Fixing cluster stats response for role types and adding search role type Signed-off-by: Vacha Shah <vachshah@amazon.com> * Add CHANGELOG Signed-off-by: Vacha Shah <vachshah@amazon.com> --------- Signed-off-by: Vacha Shah <vachshah@amazon.com> (cherry picked from commit 638d9b9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
VachaShah
added a commit
that referenced
this pull request
Feb 15, 2024
…g search role type (#849) * Fixing cluster stats response for role types and adding search role type (#848) * Fixing cluster stats response for role types and adding search role type Signed-off-by: Vacha Shah <vachshah@amazon.com> * Add CHANGELOG Signed-off-by: Vacha Shah <vachshah@amazon.com> --------- Signed-off-by: Vacha Shah <vachshah@amazon.com> (cherry picked from commit 638d9b9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fixing missing required property exception for cluster manager for 1.x servers Signed-off-by: Vacha Shah <vachshah@amazon.com> --------- Signed-off-by: Vacha Shah <vachshah@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Vacha Shah <vachshah@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When calling the cluster stats api from the client, the call fails with the following error:
Upon further debugging, I found other role types as well in the client which are not supported by OpenSearch. Fixing the cluster stats API call in this PR. I also added the
searchrole type which was added in OpenSearch 2.4.0.Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.