Add Support for Hybrid Query Type #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Varun Jain <varunudr@amazon.com>
vibrantvarun
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
Signed-off-by: Varun Jain <varunudr@amazon.com>
VachaShah
reviewed
Feb 15, 2024
There was a problem hiding this comment.
Thanks @vibrantvarun for adding this! It would be great to have the user guide and samples for hyrbid query type which would benefit the users.
|
Thanks @VachaShah . I will start working to add user guide and samples. |
VachaShah
reviewed
Feb 15, 2024
There was a problem hiding this comment.
I missed mentioning that we would also need to add an integration test for this. https://github.com/opensearch-project/opensearch-java/blob/main/java-client/src/test/java11/org/opensearch/client/opensearch/integTest/AbstractSearchRequestIT.java
|
Looks great, thank you @vibrantvarun ! |
Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
reta
approved these changes
Feb 17, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 20, 2024
* Add Support for Hybrid Query Type Signed-off-by: Varun Jain <varunudr@amazon.com> * Add samples, guide and integ tests Signed-off-by: Varun Jain <varunudr@amazon.com> * Removing wildcard imports Signed-off-by: Varun Jain <varunudr@amazon.com> * Adding import Signed-off-by: Varun Jain <varunudr@amazon.com> * Adding import Signed-off-by: Varun Jain <varunudr@amazon.com> --------- Signed-off-by: Varun Jain <varunudr@amazon.com> (cherry picked from commit 821dae6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
VachaShah
pushed a commit
that referenced
this pull request
Feb 21, 2024
* Add Support for Hybrid Query Type Signed-off-by: Varun Jain <varunudr@amazon.com> * Add samples, guide and integ tests Signed-off-by: Varun Jain <varunudr@amazon.com> * Removing wildcard imports Signed-off-by: Varun Jain <varunudr@amazon.com> * Adding import Signed-off-by: Varun Jain <varunudr@amazon.com> * Adding import Signed-off-by: Varun Jain <varunudr@amazon.com> --------- Signed-off-by: Varun Jain <varunudr@amazon.com> (cherry picked from commit 821dae6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Vacha Shah <vachshah@amazon.com>
VachaShah
pushed a commit
that referenced
this pull request
Feb 21, 2024
* Add Support for Hybrid Query Type (#850) * Add Support for Hybrid Query Type Signed-off-by: Varun Jain <varunudr@amazon.com> * Add samples, guide and integ tests Signed-off-by: Varun Jain <varunudr@amazon.com> * Removing wildcard imports Signed-off-by: Varun Jain <varunudr@amazon.com> * Adding import Signed-off-by: Varun Jain <varunudr@amazon.com> * Adding import Signed-off-by: Varun Jain <varunudr@amazon.com> --------- Signed-off-by: Varun Jain <varunudr@amazon.com> (cherry picked from commit 821dae6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Vacha Shah <vachshah@amazon.com> * Adding version check for hybrid query integ tests (#863) (#864) Signed-off-by: Varun Jain <varunudr@amazon.com> Signed-off-by: Vacha Shah <vachshah@amazon.com> --------- Signed-off-by: Varun Jain <varunudr@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Vacha Shah <vachshah@amazon.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Varun Jain <varunudr@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for hybrid query type for in hybrid search
Issues Resolved
525
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.