[FEATURE] Raise errors for HTTP error codes in the generic client #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reta
requested review from
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
reta
force-pushed
the
issue-927
branch
3 times, most recently
from
153a1e7
to
cdc127c
Compare
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
dblock
previously approved these changes
Apr 10, 2024
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
dblock
approved these changes
Apr 10, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 10, 2024
* [FEATURE] Raise errors for HTTP error codes in the generic client Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address code review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: Andriy Redko <andriy.redko@aiven.io> (cherry picked from commit 5ad54c6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
pushed a commit
that referenced
this pull request
Apr 10, 2024
* [FEATURE] Raise errors for HTTP error codes in the generic client Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address code review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: Andriy Redko <andriy.redko@aiven.io> (cherry picked from commit 5ad54c6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta
pushed a commit
that referenced
this pull request
Apr 10, 2024
…) (#931) * [FEATURE] Raise errors for HTTP error codes in the generic client * Address code review comments --------- (cherry picked from commit 5ad54c6) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provides the favour of the generic HTTP client that raises an exception if HTTP status indicates unsuccessful response.
Issues Resolved
Closes #927
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.