Fix the deserialization of SortOptions #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
bowenlan-amzn
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
dblock
approved these changes
May 13, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 13, 2024
* Fix the deserialization of SortOptions Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * add changelog Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * spotless Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> --------- Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> (cherry picked from commit e672fdc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
I scaned through the repo when working on this, don't see other places obviously having this problem. |
reta
pushed a commit
that referenced
this pull request
May 13, 2024
* Fix the deserialization of SortOptions * add changelog * spotless --------- (cherry picked from commit e672fdc) Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Not familiar with this repo. Just helping to fix the deserialization logic of SortOptions.
Reason for the failure
array deserializer invoke the deserialize method with event
opensearch-java/java-client/src/main/java/org/opensearch/client/json/JsonpDeserializerBase.java
Line 343 in d092df5
which end up throw exception for SortOptions deserializer
opensearch-java/java-client/src/main/java/org/opensearch/client/json/JsonpDeserializer.java
Line 115 in d092df5
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.