Implement TransportRequestPromise, TransportRequestCallback in AWS Signer #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gner It was previously not possible to abort a request that used the AWS SigV4 signer transport. Fixes #819 Signed-off-by: Tim Cooper <tim.cooper@layeh.com>
u873838
requested review from
ananzh,
kavilla,
dblock,
VachaShah,
nhtruong,
harshavamsi and
timursaurus
as code owners
|
This looks good! Leaving to @nhtruong to do a thorough CR. In the meantime, maybe document this feature in a user guide? |
nhtruong
approved these changes
Jul 22, 2024
|
From what described in #819, this feature is expected/the-norm so we don't need to update the doc IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was previously not possible to abort a request that used the AWS SigV4 signer transport.
Issues Resolved
Fixes #819
Check List
yarn run lintdoesn't show any errorsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.