Add missing clusterrole/codegen marker to controller #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onesolpark
requested review from
idanl21,
dbason,
swoehrl-mw,
prudhvigodithi,
jochenkressin,
pchmielnik and
salyh
as code owners
Signed-off-by: Han Sol Park <onesolpark@gmail.com>
onesolpark
force-pushed
the
add-cluster-role
branch
from
4196ffd
to
23af59b
Compare
|
Hey @swoehrl-mw @jochenkressin @pchmielnik @alyh can you please take a look. |
|
@swoehrl-mw can you please take a look, also in past I see copying the CRD's was part of helm release https://github.com/opensearch-project/opensearch-k8s-operator/pull/307/files, but now this is removed. Also please check the added RBAC roles from this PR. |
swoehrl-mw
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add missing codegen marker and auto generated clusterrole manifest.
Issues Resolved
Fixes #717
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.