Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add datastream support #735

Merged
merged 4 commits into from
Apr 5, 2024
Merged

add datastream support #735

merged 4 commits into from
Apr 5, 2024

Conversation

cgroschupp
Copy link
Contributor

@cgroschupp cgroschupp commented Feb 22, 2024 •
edited

Description

Add DataStream support to IndexTemplate.

Close #766

@cgroschupp cgroschupp force-pushed the index-template-datastream branch 3 times, most recently from 33cddae to d55bdf4 Compare February 27, 2024 07:52
@cgroschupp cgroschupp marked this pull request as ready for review February 27, 2024 09:56
@cthtrifork
Copy link
Contributor

Great! I would love this feature in the next coming release! (perhaps 2.5.2? #749)

@cgroschupp
Copy link
Contributor Author

cgroschupp commented Mar 15, 2024 •
edited

@cthtrifork As this is a new feature, I think the 2.6.0 version is better.

@idanl21 Can you please review this pull request?

@prudhvigodithi
Copy link
Collaborator

Thanks @cgroschupp for your contribution, before we get this PR merged, can you please open an issue summarizing the datastream support in detail? This way your contribution is tracked in the issue and later we can link this PR to the issue.

Adding @bbarani @salyh @jochenkressin @pchmielnik @swoehrl-mw

@cgroschupp
Copy link
Contributor Author

@prudhvigodithi done

@salyh
Copy link
Collaborator

salyh commented Mar 30, 2024

@cgroschupp Before we can get this PR merged, please refer to the PR guideline and add the mssing prerequisites. Thank you very much.

@prudhvigodithi
Copy link
Collaborator

Hey @cgroschupp we can push this to v2.6.0 #776, can you please add unit tests to this change ?
Adding @swoehrl-mw @salyh @cthtrifork can you please add your review?
Thanks

@cgroschupp
add datastream support
97bd40f 
Signed-off-by: Christian Groschupp <christian@groschupp.org>
@cgroschupp
add datastream test
a011e67 
Signed-off-by: Christian Groschupp <christian@groschupp.org>
@cgroschupp
copy opensearchindextemplates crd to helm chart
2973c9f 
Signed-off-by: Christian Groschupp <christian@groschupp.org>
@cgroschupp
Copy link
Contributor Author

@prudhvigodithi done

swoehrl-mw
swoehrl-mw requested changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@swoehrl-mw swoehrl-mw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One gripe about naming, everything else looks good

opensearch-operator/api/v1/opensearch_index_types.go Outdated

type OpensearchDatastreamSpec struct {
// TimestampField for dataStream
TimestampField OpensearchDatastreamTimestampFieldSpec `json:"timestamp_field,omitempty"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every other field is camelCase, so this should as well to be consistent

@swoehrl-mw swoehrl-mw merged commit 9fff407 into opensearch-project:main Apr 5, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swoehrl-mw swoehrl-mw swoehrl-mw approved these changes

@idanl21 idanl21 Awaiting requested review from idanl21 idanl21 is a code owner

@dbason dbason Awaiting requested review from dbason dbason is a code owner

@prudhvigodithi prudhvigodithi Awaiting requested review from prudhvigodithi prudhvigodithi is a code owner

@jochenkressin jochenkressin Awaiting requested review from jochenkressin jochenkressin is a code owner

@pchmielnik pchmielnik Awaiting requested review from pchmielnik pchmielnik is a code owner

@salyh salyh Awaiting requested review from salyh salyh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Support dataStream inside OpensearchIndexTemplate
5 participants
@cgroschupp @cthtrifork @prudhvigodithi @salyh @swoehrl-mw