-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add masked field to role #762
feat: add masked field to role #762
Conversation
80e87b4
to
dfb3f5d
Compare
Hey @cgroschupp thanks for your contribution, before we get this PR merged, can you please open an issue summarizing this change? This way your contribution is tracked in the issue and later we can link this PR to the issue. Adding @bbarani @salyh @jochenkressin @pchmielnik @swoehrl-mw |
@prudhvigodithi done |
Code changes LGTM but CI fails (https://github.com/opensearch-project/opensearch-k8s-operator/actions/runs/8359361554/job/23179427774?pr=762) @prudhvigodithi not sure if the CI failure is related to #767 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make CI green
5322c24
to
c65a65b
Compare
@salyh i found the issue with envtest and golang 1.19. i changed envtest to release-16 |
Signed-off-by: Christian Groschupp <christian@groschupp.org>
c65a65b
to
0d9ed7e
Compare
@salyh forget my last comment, i rebased by branch to use golang 1.22 |
@cgroschupp Before we can get this PR merged, please refer to the PR guideline and add the mssing prerequisites. Thank you very much. |
LGTM, @swoehrl-mw or @salyh WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- New field needs to be documented in
docs/designs/crd.md
- The extended CRD needs to be copied into the operator helm chart
@swoehrl-mw |
Signed-off-by: Christian Groschupp <christian@groschupp.org>
9467df0
to
c16cc73
Compare
@cgroschupp |
c16cc73
to
b8931e7
Compare
d53c59e
to
1264bbb
Compare
@swoehrl-mw i have updated the tests and copied the crds to the helm chart directory. for the api docs generation task i will create a new pr. |
@salyh Can you please also approve and then merge (seems merge is only allowed after all reviewers who have requested changes have approved)? |
Description
Add masked fields to OpensearchRole
Close #765