Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for adding CSI volumes as Additional Volumes #784

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

nilushancosta
Copy link
Contributor

@nilushancosta nilushancosta commented Apr 16, 2024

Description

This PR adds the capability to add CSI volumes as AdditionalVolumes in the OpenSearch cluster

Issues Resolved

Closes #275

Check List

  • Commits are signed per the DCO using --signoff
  • Unittest added for the new/changed functionality and all unit tests are successful
  • Customer-visible features documented
  • No linter warnings (make lint)

If CRDs are changed:

  • CRD YAMLs updated (make manifests) and also copied into the helm chart
  • Changes to CRDs documented

Please refer to the PR guidelines before submitting this pull request.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Nilushan Costa <nilushan@wso2.com>
Copy link
Collaborator

@swoehrl-mw swoehrl-mw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.
Please also follow up on the checklist items regarding CRD changes.

Signed-off-by: Nilushan Costa <nilushan@wso2.com>
Signed-off-by: Nilushan Costa <nilushan@wso2.com>
@nilushancosta
Copy link
Contributor Author

Thanks for the feedback @swoehrl-mw .
I completed the checklist items regarding CRD changes.

@swoehrl-mw swoehrl-mw merged commit 82f8be1 into opensearch-project:main Apr 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support adding CSI based volumes to pods
2 participants