Rename timestampField back to how it was released #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Woehrl <sebastian.woehrl@maibornwolff.de>
swoehrl-mw
requested review from
idanl21,
dbason,
prudhvigodithi,
jochenkressin,
pchmielnik and
salyh
as code owners
|
@idanl21 This should be merged quickly to not confuse other PRs |
prudhvigodithi
approved these changes
May 13, 2024
|
LGTM, thanks @swoehrl-mw |
swoehrl-mw
added a commit
to swoehrl-mw/opensearch-k8s-operator
that referenced
this pull request
May 16, 2024
…#810) ### Description Due to some oversight the timestampField from https://github.com/opensearch-project/opensearch-k8s-operator/blob/main/opensearch-operator/api/v1/opensearch_index_types.go#L14 was released as `timestamp_field` in the helm chart (https://github.com/opensearch-project/opensearch-k8s-operator/blob/v2.6.0/charts/opensearch-operator/files/opensearch.opster.io_opensearchindextemplates.yaml#L57). To prevent an incompatible renaming in the released CRDs this PR renames the field in the code to be consistent. ### Issues Resolved Originally discovered in opensearch-project#805 ### Check List - [x] Commits are signed per the DCO using --signoff - [x] Unittest added for the new/changed functionality and all unit tests are successful - [x] Customer-visible features documented - [x] No linter warnings (`make lint`) If CRDs are changed: - [-] CRD YAMLs updated (`make manifests`) and also copied into the helm chart - [-] Changes to CRDs documented By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). Signed-off-by: Sebastian Woehrl <sebastian.woehrl@maibornwolff.de> (cherry picked from commit f3455f9)
swoehrl-mw
added a commit
that referenced
this pull request
Jun 18, 2024
### Description Due to some oversight the timestampField from https://github.com/opensearch-project/opensearch-k8s-operator/blob/main/opensearch-operator/api/v1/opensearch_index_types.go#L14 was released as `timestamp_field` in the helm chart (https://github.com/opensearch-project/opensearch-k8s-operator/blob/v2.6.0/charts/opensearch-operator/files/opensearch.opster.io_opensearchindextemplates.yaml#L57). To prevent an incompatible renaming in the released CRDs this PR renames the field in the code to be consistent. ### Issues Resolved Originally discovered in #805 ### Check List - [x] Commits are signed per the DCO using --signoff - [x] Unittest added for the new/changed functionality and all unit tests are successful - [x] Customer-visible features documented - [x] No linter warnings (`make lint`) If CRDs are changed: - [-] CRD YAMLs updated (`make manifests`) and also copied into the helm chart - [-] Changes to CRDs documented By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). Signed-off-by: Sebastian Woehrl <sebastian.woehrl@maibornwolff.de> (cherry picked from commit f3455f9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to some oversight the timestampField from https://github.com/opensearch-project/opensearch-k8s-operator/blob/main/opensearch-operator/api/v1/opensearch_index_types.go#L14 was released as
timestamp_fieldin the helm chart (https://github.com/opensearch-project/opensearch-k8s-operator/blob/v2.6.0/charts/opensearch-operator/files/opensearch.opster.io_opensearchindextemplates.yaml#L57). To prevent an incompatible renaming in the released CRDs this PR renames the field in the code to be consistent.Issues Resolved
Originally discovered in #805
Check List
make lint)If CRDs are changed:
make manifests) and also copied into the helm chartBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.