2.7 #14
Open
2.7 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
hasnain2808
reviewed
Sep 27, 2023
| mapping from: /compiler.*/, to: 'lucene' | ||
| } | ||
|
|
||
| sourceSets { |
There was a problem hiding this comment.
Hi @macohen
I am trying to understand why have we replaced the sourceSets with this
The change
``` sourceSets { main { resources { srcDirs = ["config"] includes = ["**/*.yml"] } } } ```I am unable to run the plugin locally (both debug and normal mode) due to this change
It is unable to access the mapping file "fstore-index-mapping.json"
Exact eror
``` { "error": { "root_cause": [ { "type": "illegal_state_exception", "reason": "failed to create ltr feature store index with resource [fstore-index-mapping.json]" } ], "type": "illegal_state_exception", "reason": "failed to create ltr feature store index with resource [fstore-index-mapping.json]", "caused_by": { "type": "null_pointer_exception", "reason": null } }, "status": 500 } ```Without this change I am able to create .ltrstore
I might have missed details, I am starting to get my hands dirty
This PR demonstrates it
Merged
|
@gsingers would you be able to take a pass at a review here? I'd like to merge this and then create a 2.11 branch from this one. Do you see value in 2.8, 2.9, 2.10 releases for this plugin? I'd rather just skip ahead to the latest and move forward from there, but would like your input. |
macohen
commented
Oct 26, 2023
.github/workflows/release-old.yml
Outdated
| @@ -25,7 +25,7 @@ jobs: | |||
| - name: Grant execute permission for gradlew | |||
| run: chmod +x gradlew | |||
| - name: Build with Gradle | |||
| run: ./gradlew -Dtests.security.manager=false build | |||
| run: ./gradlew -Dskip.integtests=true -Djava.security.manager=allow -Dbuild.snapshot=false | |||
There was a problem hiding this comment.
skipping integ tests is temporary until we can build some more (might be able to remove). allowing the security manager and changes to the plugin-security.policy removed securitymanager violations.
There was a problem hiding this comment.
TermStatQuery tests also pass now.
|
@macohen I will take a look next week. |
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
… implementations, which are going to require some more work Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
…t cases (#3) Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mohammad Hasnain Mohsin Rajan <hasnain2808@gmail.com> Signed-off-by: Mark Cohen <markcoh@amazon.com>
Get releases working Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
…adlew Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
…re and a TODO regarding the Strings class Signed-off-by: Mark Cohen <markcoh@amazon.com>
… yamlRestTest according to spec. integTests don't work yet so running with the following vars works -Dopensearch.version=2.7.0 -Dskip.integtests=true -Djava.security.manager=allow -Dbuild.snapshot=false buid.snapshot runs the yamlRestTest successfully. -Djava.security.manager=allow allows the deprecated SecurityManager to do it's work also updated StoredFeatureParserTests.writeAsNonFormattedString to require MediaType as per opensearch-project/OpenSearch@f9eb9bf Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
' as a branch to trigger when a tag is pushed Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
… opensearch version on command line instead of in gradle.properties Signed-off-by: Mark Cohen <markcoh@amazon.com>
…is too general by subbing the semantic-ish versioning regex with a .*, but the build succeeded... Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mohammad Hasnain Mohsin Rajan <hasnain2808@gmail.com> Signed-off-by: Mark Cohen <markcoh@amazon.com>
…all out that we need to read it to ensure it's at least not a security issue Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
… docker hub doesn't work right now Signed-off-by: Mark Cohen <markcoh@amazon.com>
…ToRankPluginIT.java to look for 'ltr' in the response Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mostly updated to be compatible with OpenSearch 2.7. It doesn't publish an artifact yet, but does use some of the standard build conventions as the rest of OpenSearch. Not sure this should be merged to main until we're comfortable and it won't break the regular build process in main.
Issues Resolved
None exactly. Should start creating issues for more work.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.