custom model upload + some documenation. #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
ylwu-amzn
reviewed
Oct 20, 2022
| Class for uploading model using ml-commons apis in opensearch cluster. | ||
| """ | ||
|
|
||
| META_API_ENDPOINT = "models/meta" |
There was a problem hiding this comment.
Suggest also generate model file sha256 hash value and save in model meta doc. When ml-commons load model, it will use the hash value to verify model chunks. If can't match, will stop and throw error.
ylwu-amzn
reviewed
Oct 20, 2022
ylwu-amzn
reviewed
Oct 20, 2022
opensearch_py_ml/ml_commons_integration/upload/ml_common_upload_model.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
mingshl
approved these changes
Oct 20, 2022
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
mingshl
approved these changes
Oct 20, 2022
ylwu-amzn
reviewed
Oct 21, 2022
opensearch_py_ml/ml_commons_integration/upload/ml_common_model_uploader.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
ylwu-amzn
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dhrubo Saha dhrubo@amazon.com
Description
Through this commit customers of Opensearch will be able to upload custom model to opensearch index using mlcommons upload api.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.