Update DEVELOPER_GUIDE.md #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhrubo-os
reviewed
Mar 20, 2023
Comment on lines
+81
to
+101
| After navigating to OpenSearch Dashboards you should update the persistent settings for the cluster. The settings will update the behavior of the machine learning plugin, specifically the ml_commons plugin. ML Commons cluster settings: https://opensearch.org/docs/latest/ml-commons-plugin/cluster-settings/ | ||
|
|
||
| You should paste this settings in the `Dev Tools` window and run it: | ||
|
|
||
| ```yml | ||
| PUT /_cluster/settings | ||
| { | ||
| "persistent" : { | ||
| "plugins.ml_commons.only_run_on_ml_node" : false, | ||
| "plugins.ml_commons.native_memory_threshold" : 100, | ||
| "plugins.ml_commons.max_model_on_node": 20 | ||
| } | ||
| } | ||
| ``` |
There was a problem hiding this comment.
After looking at it again, I feel like we should move it to theNext Steps section, because this step is applicable after installing opensearch through way 1 (docker compose) or way 2 (tarball). So let's not put it under way 1.
There was a problem hiding this comment.
Ok, thanks a lot for your guidance!
|
Thanks for solving the DCO issue. |
Signed-off-by: Merey <orazaly1508@gmail.com>
Signed-off-by: Merey <orazaly1508@gmail.com>
Merey1508
force-pushed
the
upgrade_dev_guide
branch
from
3461174
to
f2097e8
Compare
dhrubo-os
approved these changes
Mar 20, 2023
ylwu-amzn
approved these changes
Mar 20, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 20, 2023
* Dev guide update Signed-off-by: Merey <orazaly1508@gmail.com> * Edited the developer guide Signed-off-by: Merey <orazaly1508@gmail.com> --------- Signed-off-by: Merey <orazaly1508@gmail.com> (cherry picked from commit f6cf39f)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 20, 2023
* Dev guide update Signed-off-by: Merey <orazaly1508@gmail.com> * Edited the developer guide Signed-off-by: Merey <orazaly1508@gmail.com> --------- Signed-off-by: Merey <orazaly1508@gmail.com> (cherry picked from commit f6cf39f)
dhrubo-os
pushed a commit
that referenced
this pull request
Mar 20, 2023
* Dev guide update Signed-off-by: Merey <orazaly1508@gmail.com> * Edited the developer guide Signed-off-by: Merey <orazaly1508@gmail.com> --------- Signed-off-by: Merey <orazaly1508@gmail.com> (cherry picked from commit f6cf39f) Co-authored-by: Merey <orazaly1508@gmail.com>
dhrubo-os
pushed a commit
that referenced
this pull request
Mar 20, 2023
* Dev guide update Signed-off-by: Merey <orazaly1508@gmail.com> * Edited the developer guide Signed-off-by: Merey <orazaly1508@gmail.com> --------- Signed-off-by: Merey <orazaly1508@gmail.com> (cherry picked from commit f6cf39f) Co-authored-by: Merey <orazaly1508@gmail.com>
dhrubo-os
pushed a commit
to dhrubo-os/opensearch-py-ml
that referenced
this pull request
Mar 30, 2023
* Dev guide update Signed-off-by: Merey <orazaly1508@gmail.com> * Edited the developer guide Signed-off-by: Merey <orazaly1508@gmail.com> --------- Signed-off-by: Merey <orazaly1508@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New contributors to the project have been facing an issue with nox testing, which has been causing delays and difficulties in their development process.
Issues Resolved
To address this, an update has been made to the Developer Guide that provides more detailed instructions before running nox tests and troubleshooting common errors. Specifically, during the office hour session, there was a discussion about updating the cluster settings.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.