Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCI][FEATURE] Add test coverage statistics to Codecov #138

Merged
merged 2 commits into from
Apr 10, 2023

Conversation

Yerzhaisang
Copy link
Contributor

Description

Fixed a bug where test coverage was incorrectly displayed in the codecov web interface
image

Issues Resolved

#118

Check List

  • [+] New functionality includes testing.
    • [+] All tests pass
  • [+] New functionality has been documented.
    • [+] New functionality has javadoc added
  • [+] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dhrubo-os
Copy link
Collaborator

can you please resolve the merge conflict and push the new changes?

bl1nkker and others added 2 commits April 8, 2023 02:11
Signed-off-by: bl1nkker <nurovich14@gmail.com>
Signed-off-by: Yerzhaisang Taskali <tasqali1697@gmail.com>
@Yerzhaisang
Copy link
Contributor Author

can you please resolve the merge conflict and push the new changes?

Done;)

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@2c73825). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #138   +/-   ##
=======================================
  Coverage        ?   89.97%           
=======================================
  Files           ?       29           
  Lines           ?     3491           
  Branches        ?        0           
=======================================
  Hits            ?     3141           
  Misses          ?      350           
  Partials        ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

opensearch-project/opensearch-py-ml \
nox -s "test-${PYTHON_VERSION}(pandas_version='${PANDAS_VERSION}')"
docker cp opensearch-py-ml-test-runner:/code/opensearch-py-ml/junit/ ./junit/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we try to add a comment here to describe why did we do it.

@dhrubo-os dhrubo-os merged commit 7ff5113 into opensearch-project:main Apr 10, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 25, 2023
* feat: added codecov integration

Signed-off-by: bl1nkker <nurovich14@gmail.com>

* fixed codecov integration

Signed-off-by: Yerzhaisang Taskali <tasqali1697@gmail.com>

---------

Signed-off-by: bl1nkker <nurovich14@gmail.com>
Signed-off-by: Yerzhaisang Taskali <tasqali1697@gmail.com>
Co-authored-by: bl1nkker <nurovich14@gmail.com>
(cherry picked from commit 7ff5113)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 25, 2023
* feat: added codecov integration

Signed-off-by: bl1nkker <nurovich14@gmail.com>

* fixed codecov integration

Signed-off-by: Yerzhaisang Taskali <tasqali1697@gmail.com>

---------

Signed-off-by: bl1nkker <nurovich14@gmail.com>
Signed-off-by: Yerzhaisang Taskali <tasqali1697@gmail.com>
Co-authored-by: bl1nkker <nurovich14@gmail.com>
(cherry picked from commit 7ff5113)
dhrubo-os pushed a commit that referenced this pull request Apr 25, 2023
* feat: added codecov integration

Signed-off-by: bl1nkker <nurovich14@gmail.com>

* fixed codecov integration

Signed-off-by: Yerzhaisang Taskali <tasqali1697@gmail.com>

---------

Signed-off-by: bl1nkker <nurovich14@gmail.com>
Signed-off-by: Yerzhaisang Taskali <tasqali1697@gmail.com>
Co-authored-by: bl1nkker <nurovich14@gmail.com>
(cherry picked from commit 7ff5113)

Co-authored-by: Yerzhaisang <55043014+Yerzhaisang@users.noreply.github.com>
dhrubo-os pushed a commit that referenced this pull request Apr 25, 2023
* feat: added codecov integration

Signed-off-by: bl1nkker <nurovich14@gmail.com>

* fixed codecov integration

Signed-off-by: Yerzhaisang Taskali <tasqali1697@gmail.com>

---------

Signed-off-by: bl1nkker <nurovich14@gmail.com>
Signed-off-by: Yerzhaisang Taskali <tasqali1697@gmail.com>
Co-authored-by: bl1nkker <nurovich14@gmail.com>
(cherry picked from commit 7ff5113)

Co-authored-by: Yerzhaisang <55043014+Yerzhaisang@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants