added documentation + fixed ipynb files #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
ylwu-amzn
reviewed
Nov 1, 2022
| other words, provide a small test case which we can run to confirm your | ||
| bug. It makes it easier to find the problem and to fix it. Test cases | ||
| should be provided as python scripts, ideally with some details of your | ||
| Elasticsearch environment and index mappings, and (where appropriate) a |
There was a problem hiding this comment.
I'll delete this file in the next PR (mistakenly uploaded). I'm referring to our Contributing.md
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
ylwu-amzn
reviewed
Nov 2, 2022
| +---------------------------------------+------------+ | ||
| | Method or Property | Supported? | | ||
| +=======================================+============+ | ||
| | ``ed.DataFrame.abs()`` | No | |
There was a problem hiding this comment.
Good Question. ed is used as short form of eland. I was looking at that file. This file is auto generated. I pushed a commit to delete this file and later I will fork the code to generate this rst by itself.
There was a problem hiding this comment.
Cool, actually I see ed in other files too.
There was a problem hiding this comment.
Yeah, those are in the code files. To reflect/change the variable name, requires another larger PR, which I'm planning to do after this PR.
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
ylwu-amzn
approved these changes
Nov 2, 2022
rbhavna
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dhrubo Saha dhrubo@amazon.com
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.