Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release workflows #27

Merged
merged 7 commits into from
Nov 18, 2022
Merged

Add release workflows #27

merged 7 commits into from
Nov 18, 2022

Conversation

gaiksaya
Copy link
Member

Description

This PR adds below things:

  • A GitHub action workflow that will be triggered when a tag is pushed to this repository. The workflow builds the product and creates a draft release with built artifacts attached as artifacts.tar.gz in the release.
  • A jenkins workflow that is triggered based on above draft release. The workflow looks for artifacts.tar.gz, downloads it and then signs it and publishes it to PyPi

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
@gaiksaya gaiksaya changed the title Test Add release workflows Nov 17, 2022
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
on:
push:
tags:
- "*"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a comment here: # Push events to every tag not containing /

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't quite get that. This workflow will be triggered irrespective of any type of tag. Is there a plan to push specifically named tags?
Also my understanding is tag will be pushed when you want to release this product. Correct me if I am wrong please.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the documentation it looks like * is for Matches all branch and tag names that don't contain a slash (/).

I just wanted to add that here as a comment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tags options on line 5 will look only for tags and not branches. I can add a comment you asked just for as an information.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@gaiksaya
Copy link
Member Author

gaiksaya commented Nov 17, 2022

Making some changes on core library. We found out that the api tokens used to publish the packages on pypi can be scoped per package. We are working on making some changes. Please wait till I make some changes in this PR.
Thanks!

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
@gaiksaya gaiksaya merged commit aafa2ab into opensearch-project:main Nov 18, 2022
@gaiksaya gaiksaya deleted the test branch November 18, 2022 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants