add demo notebook and return model #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingshl
force-pushed
the
test
branch
3 times, most recently
from
b7a2d45
to
8a38c47
Compare
ylwu-amzn
reviewed
Nov 21, 2022
...ples/demo_notebook_for_sentence_transformer_model_training_and_uploading_to_openSearch.ipynb
Outdated
Show resolved
Hide resolved
Signed-off-by:<Mingshi Liu><mingshl@amazon.com> Signed-off-by: Mingshi Liu <mingshl@amazon.com>
Signed-off-by:<Mingshi Liu><mingshl@amazon.com> Signed-off-by: Mingshi Liu <mingshl@amazon.com>
Signed-off-by:<Mingshi Liu><mingshl@amazon.com> Signed-off-by: Mingshi Liu <mingshl@amazon.com>
Signed-off-by:<Mingshi Liu><mingshl@amazon.com> Signed-off-by: Mingshi Liu <mingshl@amazon.com>
Signed-off-by: Mingshi Liu <mingshl@amazon.com>
Signed-off-by: Mingshi Liu <mingshl@amazon.com>
dhrubo-os
approved these changes
Nov 22, 2022
Signed-off-by: Mingshi Liu <mingshl@amazon.com>
Signed-off-by: Mingshi Liu <mingshl@amazon.com>
ylwu-amzn
approved these changes
Nov 22, 2022
gaiksaya
pushed a commit
to gaiksaya/opensearch-py-ml
that referenced
this pull request
Feb 10, 2023
* add demo notebook and modify docstring Signed-off-by:<Mingshi Liu><mingshl@amazon.com> Signed-off-by: Mingshi Liu <mingshl@amazon.com> * add demo notebook and return model Signed-off-by:<Mingshi Liu><mingshl@amazon.com> Signed-off-by: Mingshi Liu <mingshl@amazon.com> * change imports to import Signed-off-by:<Mingshi Liu><mingshl@amazon.com> Signed-off-by: Mingshi Liu <mingshl@amazon.com> * add docs and modify demo notebook Signed-off-by:<Mingshi Liu><mingshl@amazon.com> Signed-off-by: Mingshi Liu <mingshl@amazon.com> * edit for docs Signed-off-by: Mingshi Liu <mingshl@amazon.com> * edit2 for docs Signed-off-by: Mingshi Liu <mingshl@amazon.com> * edit title in notebook Signed-off-by: Mingshi Liu <mingshl@amazon.com> * edit2 title in notebook Signed-off-by: Mingshi Liu <mingshl@amazon.com> Signed-off-by: Mingshi Liu <mingshl@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add demo notebook and return torch script model in train and save_as_pt function.
Issues Resolved
returning model will be helpful to generate embedding and inference to validate with the results after uploading model to OpenSearch
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.