-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unnecessary utf-8 header in .py files #615
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #615 +/- ##
=======================================
Coverage 71.98% 71.98%
=======================================
Files 89 89
Lines 7935 7935
=======================================
Hits 5712 5712
Misses 2223 2223 ☔ View full report in Codecov by Sentry. |
Signed-off-by: samuel orji <awesomeorji@gmail.com>
56a57a6
to
bddee0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit, thanks.
CHANGELOG.md
Outdated
@@ -10,6 +10,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
### Changed | |||
### Deprecated | |||
### Removed | |||
- Removed Unnecessary `# -*- coding: utf-8 -*-` headers from .py files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this look like other changelog lines, lowercase unnecessary and add a link to the PR.
Signed-off-by: samuel orji <awesomeorji@gmail.com>
) (#617) * License tools: remove utf-8 coding declaration from license_headers.py check/fix script; since #615 it is no longer used in the library's codebase UTF-8 is the default encoding used to read source code files for Python3 - see https://docs.python.org/3/howto/unicode.html#unicode-literals-in-python-source-code Signed-off-by: James Addison <james@reciperadar.com> * Cleanup: remove utf-8 coding declaration from the license_headers.py script itself Signed-off-by: James Addison <james@reciperadar.com> * Update CHANGELOG.md Signed-off-by: James Addison <james@reciperadar.com> --------- Signed-off-by: James Addison <james@reciperadar.com>
* remove unnecessary utf-8 header in .py files Signed-off-by: samuel orji <awesomeorji@gmail.com> * review feedback: add link to changelog Signed-off-by: samuel orji <awesomeorji@gmail.com> --------- Signed-off-by: samuel orji <awesomeorji@gmail.com> Signed-off-by: roma2023 <romasaparhan19@gmail.com>
…pensearch-project#615) (opensearch-project#617) * License tools: remove utf-8 coding declaration from license_headers.py check/fix script; since opensearch-project#615 it is no longer used in the library's codebase UTF-8 is the default encoding used to read source code files for Python3 - see https://docs.python.org/3/howto/unicode.html#unicode-literals-in-python-source-code Signed-off-by: James Addison <james@reciperadar.com> * Cleanup: remove utf-8 coding declaration from the license_headers.py script itself Signed-off-by: James Addison <james@reciperadar.com> * Update CHANGELOG.md Signed-off-by: James Addison <james@reciperadar.com> --------- Signed-off-by: James Addison <james@reciperadar.com> Signed-off-by: roma2023 <romasaparhan19@gmail.com>
Description
Remove Unnecessary
# -*- coding: utf-8 -*-
headers from .py filesIssues Resolved
#613
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.