Added fix for key error because of missing 'hits' key. #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Djcarrillo6
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
deztructor,
Shephalimittal,
saimedhi and
florianvazelle
as code owners
Djcarrillo6
force-pushed
the
fix/issue-313/graceful-empty-scan-result-handling
branch
from
e3adfc3
to
71137f2
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #616 +/- ##
==========================================
+ Coverage 71.98% 72.12% +0.14%
==========================================
Files 89 89
Lines 7935 7939 +4
==========================================
+ Hits 5712 5726 +14
+ Misses 2223 2213 -10 ☔ View full report in Codecov by Sentry. |
Djcarrillo6
force-pushed
the
fix/issue-313/graceful-empty-scan-result-handling
branch
from
71137f2
to
4df886c
Compare
dblock
reviewed
Nov 26, 2023
There was a problem hiding this comment.
AFAIK tests should go next to other scroll tests, so in test_actions.py?
Btw, tests aren't very well organized, my rule of thumb is that for every file like actions.py there should be one test_actions.py and if actions is a kitchen sink of many things, i can be split up into a folder called actions with files such as scroll.py, and tests organized similarly. So whatever gets us closer to that is A-OK.
Djcarrillo6
force-pushed
the
fix/issue-313/graceful-empty-scan-result-handling
branch
2 times, most recently
from
63aa1eb
to
64f2f6b
Compare
saimedhi
reviewed
Nov 27, 2023
Signed-off-by: Djcarrillo6 <djcarrillo6@yahoo.com> Updated CHANGELOG.md. Signed-off-by: Djcarrillo6 <djcarrillo6@yahoo.com> nox formatting applied. Signed-off-by: Djcarrillo6 <djcarrillo6@yahoo.com> Added new unit test for actions scan function. Signed-off-by: Djcarrillo6 <djcarrillo6@yahoo.com> Added type hints & nox formatting. Signed-off-by: Djcarrillo6 <djcarrillo6@yahoo.com> Added fix to async scan function & added matching unit tests for async. Signed-off-by: Djcarrillo6 <djcarrillo6@yahoo.com>
Djcarrillo6
force-pushed
the
fix/issue-313/graceful-empty-scan-result-handling
branch
from
64f2f6b
to
fad9307
Compare
dblock
approved these changes
Dec 4, 2023
roma2023
pushed a commit
to roma2023/opensearch-py
that referenced
this pull request
Dec 28, 2023
…oject#616) Updated CHANGELOG.md. nox formatting applied. Added new unit test for actions scan function. Added type hints & nox formatting. Added fix to async scan function & added matching unit tests for async. Signed-off-by: Djcarrillo6 <djcarrillo6@yahoo.com> Signed-off-by: roma2023 <romasaparhan19@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds graceful/defensive code for handling case of missing "hits" key in scan response.
Issues Resolved
Closes #313
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.