Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unnecessary-dunder-call for pylint; exception caught in run_tests.py #655

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

macohen
Copy link
Contributor

@macohen macohen commented Jan 21, 2024

added unnecessary-dunder-call to pylintrc files lines

in run_tests.py, exception thrown by 'git remote add origin' when the remote already exists will not exit

Description

  • unnecessary-dunder-call is a lint that finds any calls to magic or "dunder" functions ( *) that could be replaced by the operator or non-dunder function higher level call
  • also run_tests.py catches an exception thrown by git remote add origin when the remote already exists instead of exiting

Issues Resolved

Progress on #610

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

… lines

in run_tests.py, exception thrown by 'git remote add origin' when the remote already exists will not exit

Signed-off-by: Mark Cohen <markcoh@amazon.com>
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c66e8c) 72.13% compared to head (e358d1f) 72.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #655   +/-   ##
=======================================
  Coverage   72.13%   72.13%           
=======================================
  Files          89       89           
  Lines        7945     7945           
=======================================
  Hits         5731     5731           
  Misses       2214     2214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblock dblock merged commit 6e58837 into opensearch-project:main Jan 22, 2024
53 of 61 checks passed
@macohen macohen deleted the implement-dot-pylint branch January 22, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants