Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance generator to update changelog only if generated code differs from existing #684

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

saimedhi
Copy link
Collaborator

@saimedhi saimedhi commented Mar 4, 2024

Description

Enhance generator to update changelog only if generated code differs from existing code.

Issues Resolved

#680 (comment)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…from existing

Signed-off-by: saimedhi <saimedhi@amazon.com>
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.14%. Comparing base (4b69c09) to head (ab8d612).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #684   +/-   ##
=======================================
  Coverage   72.14%   72.14%           
=======================================
  Files          89       89           
  Lines        7945     7945           
=======================================
  Hits         5732     5732           
  Misses       2213     2213           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…from existing

Signed-off-by: saimedhi <saimedhi@amazon.com>
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge, but this seems a little complicated.

Would it make things simpler to do the rm -rf, generate the code into opensearchpy, then look at git status to see what has changed?

@dblock dblock merged commit d36a882 into opensearch-project:main Mar 4, 2024
43 of 55 checks passed
@saimedhi
Copy link
Collaborator Author

saimedhi commented Mar 4, 2024

I'll merge, but this seems a little complicated.

Would it make things simpler to do the rm -rf, generate the code into opensearchpy, then look at git status to see what has changed?

I'll give that approach a try. Just want to make sure files like .pycache won't cause any issues.

@dblock
Copy link
Member

dblock commented Mar 4, 2024

I'll merge, but this seems a little complicated.
Would it make things simpler to do the rm -rf, generate the code into opensearchpy, then look at git status to see what has changed?

I'll give that approach a try. Just want to make sure files like .pycache won't cause any issues.

Anything generated should be in .gitignore.

@dblock
Copy link
Member

dblock commented Mar 4, 2024

I'll give that approach a try.

Btw, I think it's not important what has changed. The workflow that runs this check could generate the code, then check whether anything has changed, and only if something has generate the changelog. Then try opening the PR which would do nothing if there were no changes.

AbitraryYu pushed a commit to AbitraryYu/opensearch-py that referenced this pull request Apr 22, 2024
…from existing (opensearch-project#684)

* Enhance generator to update changelog only if generated code differs from existing

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Enhance generator to update changelog only if generated code differs from existing

Signed-off-by: saimedhi <saimedhi@amazon.com>

---------

Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: AbitraryYu <nikkoyhc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants