Adding support for extension to register transport actions #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
…aratvemulapalli/opensearch-sdk-java into tranport-action-for-helloworld
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
dbwiddis
previously approved these changes
Sep 30, 2022
| @@ -126,6 +121,7 @@ public ExtensionsRunner() throws IOException { | |||
| .put(TransportSettings.PORT.getKey(), extensionSettings.getHostPort()) | |||
| .build(); | |||
| this.customSettings = Collections.emptyList(); | |||
| this.transportActions = new TransportActions(Collections.EMPTY_MAP); | |||
There was a problem hiding this comment.
Prefer Collections.emptyMap() here (which just wraps EMPTY_MAP with an inferred <T> cast) which is friendlier to code/IDEs and avoids downstream unchecked cast warnings.
owaiskazi19
previously approved these changes
Sep 30, 2022
|
This PR is waiting on : opensearch-project/OpenSearch#4598 |
This was referenced Oct 10, 2022
into tranport-action-for-helloworld
dbwiddis
approved these changes
Oct 10, 2022
There was a problem hiding this comment.
Resolved conflicts. This was previously approved by myself and @owaiskazi19 and needs to get merged ASAP as the build is broken and is blocking #172
Codecov Report
@@ Coverage Diff @@
## main #164 +/- ##
============================================
- Coverage 66.00% 65.79% -0.22%
Complexity 96 96
============================================
Files 25 25
Lines 456 459 +3
Branches 13 13
============================================
+ Hits 301 302 +1
- Misses 147 149 +2
Partials 8 8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
owaiskazi19
approved these changes
Oct 10, 2022
Thanks @dbwiddis for resolving the conflicts. |
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 17, 2023
…h-project#164) * Adding support for extension to register transport actions Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com> * Adding java doc Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com> * Adding support for extension to register transport actions Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com> * Rebasing Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com> * Fixing gradle check and adding java docs Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com> * Removed TransportAction Response Handler Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com> * Fixing typo's Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com> Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com> Co-authored-by: Daniel Widdis <widdis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sarat Vemulapalli vemulapallisarat@gmail.com
Description
Adding support for hello world extension to write up custom transport actions.
Issues Resolved
#119
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.