Combine version strings for multi-module dependencies #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
force-pushed
the
combineVersions
branch
from
7d86c52
to
fcb384a
Compare
|
Should we keep a variable for |
owaiskazi19
reviewed
Nov 4, 2022
owaiskazi19
reviewed
Nov 4, 2022
Signed-off-by: Daniel Widdis <widdis@gmail.com>
My usual preference is to have all versions as separate properties. My fix commit crossed paths with your comments -- do you want me to change all dependencies in the file to the same format? |
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Looks like you already did. Looks clean now! |
owaiskazi19
approved these changes
Nov 4, 2022
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 17, 2023
…ject#233) * Combine version strings for multi-module dependencies Signed-off-by: Daniel Widdis <widdis@gmail.com> * Need double quotes to evaluate substitutions in Groovy Signed-off-by: Daniel Widdis <widdis@gmail.com> * Unify format for all dependencies Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Daniel Widdis <widdis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Widdis widdis@gmail.com
Description
Reduces the noise of dependabot updates by only having a single version to update.
Issues Resolved
Fixes #229
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.