issue # 49 Rename and possibly move static method for determining local ephemeral address #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mloufra <mloufra@amazon.com>
Signed-off-by: mloufra <mloufra@amazon.com>
Signed-off-by: mloufra <mloufra@amazon.com>
5 tasks
joshpalis
reviewed
Aug 11, 2022
| @@ -248,7 +248,11 @@ public void startTransportService(TransportService transportService) { | |||
| false, | |||
| false, | |||
| InitializeExtensionsRequest::new, | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
Seems like you missed a merge conflict
Signed-off-by: mloufra <mloufra@amazon.com>
owaiskazi19
approved these changes
Aug 12, 2022
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 17, 2023
…al ephemeral address (opensearch-project#85) * issue opensearch-project#28 Signed-off-by: mloufra <mloufra@amazon.com> * Update the lastest coomit Signed-off-by: mloufra <mloufra@amazon.com> * Rename the method getLocalEphemeral to createLocalEphemeralAddress Signed-off-by: mloufra <mloufra@amazon.com> * Change access modifier Signed-off-by: mloufra <mloufra@amazon.com> Signed-off-by: mloufra <mloufra@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mloufra mloufra@amazon.com
Description
The ActionListener class has a protected static method getLocalEphemeral().
Subclasses can't access static method so protected access is inappropriate. Consider making private if only this class will use it. Consider refactoring to another class if it's going to be used by other classes
As it's not a field accessor, get*() is not the best name. Consider createLocalEphemeralAddress().
Issues Resolved
#49
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.