Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pre commit support. #18

Merged
merged 3 commits into from
Sep 8, 2023
Merged

Conversation

dblock
Copy link
Member

@dblock dblock commented Sep 8, 2023

Description

  1. Adds a pre-commit hook.
  2. Adds poetry exec auto.

Neither are automatic, you have to install something. Poetry doesn't have a way to "just run scripts".

Issues Resolved

Closes #9.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock changed the title Pre commit Added pre commit support. Sep 8, 2023
Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@dbwiddis dbwiddis merged commit 4a93302 into opensearch-project:main Sep 8, 2023
4 checks passed
@dblock dblock deleted the pre-commit branch September 21, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Single line formatting script
2 participants