Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use properties. #29

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Conversation

dblock
Copy link
Member

@dblock dblock commented Sep 11, 2023

Description

From #28 (review).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@amazon.com>
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #29 (7e29371) into main (b92e9f5) will increase coverage by 0.23%.
Report is 1 commits behind head on main.
The diff coverage is 95.12%.

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   93.44%   93.68%   +0.23%     
==========================================
  Files          43       47       +4     
  Lines        1205     1282      +77     
==========================================
+ Hits         1126     1201      +75     
- Misses         79       81       +2     
Files Changed Coverage Δ
...xtensions_restexecuteonextensiontaction_handler.py 72.22% <33.33%> (ø)
...c/opensearch_sdk_py/rest/extension_rest_handler.py 81.81% <81.81%> (ø)
...s/internal/discovery_extensions_request_handler.py 72.22% <100.00%> (+1.63%) ⬆️
.../opensearch_sdk_py/rest/extension_rest_handlers.py 100.00% <100.00%> (ø)
.../opensearch_sdk_py/rest/extension_rest_response.py 100.00% <100.00%> (ø)
src/opensearch_sdk_py/rest/named_route.py 100.00% <100.00%> (ø)
...earch_sdk_py/transport/outbound_message_request.py 100.00% <100.00%> (ø)

Signed-off-by: dblock <dblock@amazon.com>
Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also use properties for routes here and here?

Signed-off-by: dblock <dblock@amazon.com>
@dblock
Copy link
Member Author

dblock commented Sep 11, 2023

Should we also use properties for routes here and here?

Yep, done.

@dbwiddis dbwiddis merged commit 95ddfb1 into opensearch-project:main Sep 11, 2023
6 checks passed
@dblock dblock deleted the interfaces-properties branch September 11, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants