Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow OpenSearch Docker image to be pulled from Amazon ECR #49

Closed
wants to merge 1 commit into from
Closed

Allow OpenSearch Docker image to be pulled from Amazon ECR #49

wants to merge 1 commit into from

Conversation

ginkel
Copy link
Contributor

@ginkel ginkel commented Dec 19, 2022

Description

Official OpenSearch Docker images are available off Docker Hub and Amazon ECR (cf. https://opensearch.org/docs/2.4/install-and-configure/install-opensearch/docker/#run-opensearch-in-a-docker-container). This PR adds built-in support for using the ECR-based images.

Issues Resolved

n/a

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Thilo-Alexander Ginkel <tg@tgbyte.de>
@reta
Copy link
Collaborator

reta commented Dec 19, 2022

thanks for pull request @ginkel , please check the official recommendations for image name substitution from Testcontainers: https://www.testcontainers.org/features/image_name_substitution/ (also documented testcontainers/testcontainers-java#4219 and testcontainers/testcontainers-java#3102)

@ginkel
Copy link
Contributor Author

ginkel commented Dec 19, 2022

@reta Thanks for your speedy reply! If you consider a built-in allow-listing of the ECR images inappropriate, feel free to disregard my PR. The reason for creating it was that I was actually surprised having to manually declare the ECR-hosted official image as compatible. That's easy to do, but was somewhat unexpected...

@reta
Copy link
Collaborator

reta commented Dec 19, 2022

Thanks @ginkel , I think the issue is, broadly, to support any Docker repository in a way that is aligned with Testcontainers. I believe we should not take the path of ad-hoc ECR / GCR / ... support.

@ginkel ginkel closed this Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants