Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] missing gradle plugin support for dependencies in plugin descriptor properties with semver range #13187

Open
rursprung opened this issue Apr 15, 2024 · 6 comments
Assignees
Labels
Build Libraries & Interfaces Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. enhancement Enhancement or improvement to existing feature or request Plugins

Comments

@rursprung
Copy link
Contributor

rursprung commented Apr 15, 2024

Is your feature request related to a problem? Please describe

#11441 added support for semver ranges in dependencies of plugins. however, there's no way to use this with the gradle plugin used to build plugins (opensearchplugin from org.opensearch.gradle:build-tools).

Describe the solution you'd like

  • it must be possible to specify this new kind of dependencies also using the gradle plugin. i.e. it should be easily possible to just say "this OpenSearch plugin is compatible with OpenSearch >= 2.13" using gradle code without having to manually write the plugin descriptor file (since the gradle plugin is supposed to take care of it).
  • opensearch-plugin-template-java should be updated to use this and show it as best practices.
  • other OpenSearch plugins may or may not be updated to match this (depends on whether it makes sense for them - though for patch releases it might make sense so that in the future you're not forced to re-release each and every one of them even if nothing changed there?)

Related component

Plugins

Describe alternatives you've considered

the plugin descriptor file could be written manually, but then a lot of the automation coming from the gradle plugin would no longer be used, which makes no sense.

Additional context

see #11441 (comment) and following comments

CC @dblock, @saratvemulapalli & @abseth-amzn

@rursprung rursprung added enhancement Enhancement or improvement to existing feature or request untriaged labels Apr 15, 2024
@saratvemulapalli
Copy link
Member

💯 @rursprung . It makes a lot of sense, most of the plugin developers use gradle plugin to dependencies and packaging.

@peternied
Copy link
Member

[Triage - attendees 1 2 3 4 5 6 7]
@rursprung Thanks for reporting this issue

@peternied peternied added Build Libraries & Interfaces Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. and removed untriaged labels Apr 17, 2024
@saratvemulapalli
Copy link
Member

@rursprung do you want to contribute the change?

@rursprung
Copy link
Contributor Author

@rursprung do you want to contribute the change?

sorry, but i won't have time for this :(

@dblock
Copy link
Member

dblock commented Apr 17, 2024

Maybe @abseth-amzn is interested in picking this up?

@abseth-amzn
Copy link
Contributor

@dblock - I can pick this up next week (oncall currently)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Libraries & Interfaces Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. enhancement Enhancement or improvement to existing feature or request Plugins
Projects
None yet
Development

No branches or pull requests

5 participants