Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Release workflow is missing 2PR approval process #691

Closed
gaiksaya opened this issue Apr 7, 2023 · 1 comment · Fixed by #686
Closed

[BUG] Release workflow is missing 2PR approval process #691

gaiksaya opened this issue Apr 7, 2023 · 1 comment · Fixed by #686
Labels
bug Something isn't working

Comments

@gaiksaya
Copy link
Member

gaiksaya commented Apr 7, 2023 •
edited
Loading

Describe the bug

Adding this issue as bug because the current 1-click process in this repository lacks this feature. See details here opensearch-project/opensearch-build#3111
Sample PR: opensearch-project/opensearch-java#383

To Reproduce
Push a tag to this repo and see the product get released

Expected behavior
The release-drafter workflow should be blocked asking for approval from 2 maintainers/codewoners to approve the release.
@gaiksaya gaiksaya added bug Something isn't working untriaged labels Apr 7, 2023
@gaiksaya gaiksaya mentioned this issue Apr 7, 2023
Closed
@gaiksaya gaiksaya changed the title [BUG] Onboard to 2PR approval process [BUG] Release workflow is missing 2PR approval process Apr 7, 2023
@BSFishy BSFishy mentioned this issue Apr 7, 2023
Merged
6 tasks
@BSFishy
Copy link
Contributor

BSFishy commented Apr 7, 2023

Fixed in #686

@BSFishy BSFishy removed the untriaged label Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add 2 party approval process for releases BSFishy/oui
2 participants
@BSFishy @gaiksaya