Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions #305

Closed
Tracked by #125
dblock opened this issue Feb 14, 2023 · 5 comments
Closed
Tracked by #125
Assignees

Comments

@dblock
Copy link
Member

dblock commented Feb 14, 2023

Follow opensearch-project/.github#125 to baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions.

Close this issue when:

  1. MAINTAINERS.md has the correct list of project maintainers.
  2. CODEOWNERS exists and has the correct list of aliases.
  3. Repo permissions only contain individual aliases as collaborators with maintain rights, admin, and triage teams.
  4. All other teams are removed from repo permissions.

If this repo's permissions was already baselined, please confirm the above when closing this issue.

@gaiksaya
Copy link
Member

gaiksaya commented Mar 4, 2023

Please onboard to 2PR approval process after CODEOWNER's file is updated.
Details: opensearch-project/opensearch-build#3111
Sample PR: opensearch-project/opensearch-java#383

Created issue #691 to track this

@AbhishekReddy1127 AbhishekReddy1127 self-assigned this Mar 9, 2023
ananzh added a commit to ananzh/oui that referenced this issue Apr 5, 2023
Issue Resolve
opensearch-project#305

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh mentioned this issue Apr 5, 2023
6 tasks
opensearch-trigger-bot bot pushed a commit that referenced this issue Apr 6, 2023
Issue Resolve
#305

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
(cherry picked from commit 57d6bc8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@bbarani
Copy link
Member

bbarani commented Apr 6, 2023

The permissions are still not correct. I still see 2 teams with maintainer rights. There should be no other team added to the repo except for admin and triage team. Everyone else should be added as individual user. @ananzh @seanneumann

The below teams are still part of the permission group.

@opensearch-project/opensearch-dashboards-core • 11 members
@opensearch-project/oui • 10 members

@bbarani bbarani reopened this Apr 6, 2023
ananzh pushed a commit that referenced this issue Apr 7, 2023
Issue Resolve
#305


(cherry picked from commit 57d6bc8)

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ananzh
Copy link
Member

ananzh commented Apr 7, 2023

Hi @bbarani, @BSFishy will work with build team on-call to update permissions.

@ananzh
Copy link
Member

ananzh commented Apr 20, 2023

We have updated CODEOWNER and MAINTAINERS.
Also have @gaiksaya updated the permissions: #668 (comment).
Close this issue.

@ananzh ananzh closed this as completed Apr 20, 2023
@dblock
Copy link
Member Author

dblock commented Apr 24, 2023

Verified, thx.

SergeyMyssak pushed a commit to SergeyMyssak/oui that referenced this issue May 10, 2023
Issue Resolve
opensearch-project#305


(cherry picked from commit 57d6bc8)

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants