Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCI] Fix deprecated webpack configuration #578

Conversation

SergeyMyssak
Copy link
Collaborator

Description

Fix deprecated webpack configuration

Issues Resolved

#577

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com>
@SergeyMyssak SergeyMyssak requested a review from a team as a code owner March 8, 2023 11:39
@SergeyMyssak SergeyMyssak changed the title Fix deprecated webpack configuration (#577) [CCI] Fix deprecated webpack configuration (#577) Mar 8, 2023
@SergeyMyssak SergeyMyssak changed the title [CCI] Fix deprecated webpack configuration (#577) [CCI] Fix deprecated webpack configuration Mar 8, 2023
@ashwin-pc ashwin-pc added the CCI College Contributor Initiative label Mar 8, 2023
@joshuarrrr
Copy link
Member

@SergeyMyssak This looks good and all automated tests pass. Any other guidance on the best way to validate/test?

@BSFishy
Copy link
Contributor

BSFishy commented Mar 9, 2023

I think at the very least we need to make sure yarn build and yarn build-docs both work as intended

Copy link
Contributor

@BSFishy BSFishy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes on yarn build and yarn build-docs

@BSFishy BSFishy mentioned this pull request Mar 9, 2023
31 tasks
@BSFishy BSFishy merged commit f936098 into opensearch-project:main Mar 10, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 10, 2023
Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com>
(cherry picked from commit f936098)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 10, 2023
Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com>
(cherry picked from commit f936098)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ashwin-pc pushed a commit that referenced this pull request Mar 10, 2023
(cherry picked from commit f936098)

Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ashwin-pc pushed a commit that referenced this pull request Mar 10, 2023
(cherry picked from commit f936098)

Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x backport 1.0 CCI College Contributor Initiative
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants