Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a11y tests to workflow #641

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add a11y tests to workflow #641

wants to merge 3 commits into from

Conversation

BSFishy
Copy link
Contributor

@BSFishy BSFishy commented Mar 28, 2023

Description

Run accessibility tests when running the build and test workflow. The tests are and have been in the repository for a while, not sure why they weren't included in the workflow

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@BSFishy
Add a11y tests to workflow
7802aba 
Signed-off-by: Matt Provost <provomat@amazon.com>
@BSFishy BSFishy requested a review from a team as a code owner March 28, 2023 21:09
@BSFishy
Add cross-env to start-test-server script
d80c42f 
Signed-off-by: Matt Provost <provomat@amazon.com>
@BSFishy
Copy link
Contributor Author

BSFishy commented Mar 28, 2023

Accessibility errors will go away when #640 is merged

ashwin-pc
ashwin-pc requested changes Mar 30, 2023
View reviewed changes
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ddint see the test failures before i approved them, can we also fix the a11y issues before adding them to the CI? No point adding something to the CI thats broken, making the CI useless.

@BSFishy BSFishy mentioned this pull request May 18, 2023
Closed
6 tasks
@BSFishy BSFishy self-assigned this Jul 18, 2023
@BSFishy
Copy link
Contributor Author

BSFishy commented Aug 7, 2023

Converting to draft until we get guidance on how to fix a11y issues

@BSFishy BSFishy marked this pull request as draft August 7, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwin-pc ashwin-pc ashwin-pc requested changes

@joshuarrrr joshuarrrr joshuarrrr approved these changes

@seanneumann seanneumann Awaiting requested review from seanneumann

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@rednaksi91 rednaksi91 Awaiting requested review from rednaksi91 rednaksi91 is a code owner

@KrooshalUX KrooshalUX Awaiting requested review from KrooshalUX

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@andreymyssak andreymyssak Awaiting requested review from andreymyssak andreymyssak is a code owner

@SergeyMyssak SergeyMyssak Awaiting requested review from SergeyMyssak SergeyMyssak is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@BSFishy BSFishy

Labels
backport 1.x backport 1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BSFishy @joshuarrrr @ashwin-pc